ext_proc: Remove extra spaces from proto comments causing git-push failure.#42809
Merged
agrawroh merged 1 commit intoenvoyproxy:mainfrom Dec 30, 2025
Merged
ext_proc: Remove extra spaces from proto comments causing git-push failure.#42809agrawroh merged 1 commit intoenvoyproxy:mainfrom
agrawroh merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Sumit Kumar <sumitkmr@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
Author
|
@markdroth FYI. |
Contributor
|
/lgtm api |
agrawroh
approved these changes
Dec 30, 2025
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
…ilure. (envoyproxy#42809) <!-- !!!ATTENTION!!! If you are fixing *any* crash or *any* potential security issue, *do not* open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure. !!!ATTENTION!!! For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md) !!!ATTENTION!!! Please check the [use of generative AI policy](https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md?plain=1#L41). You may use generative AI only if you fully understand the code. You need to disclose this usage in the PR description to ensure transparency. --> Commit Message: Remove extra spaces from proto comments causing git-push failure. Additional Description: After pulling latest main, git-push started failing with this error ``` ERROR: From ./api/envoy/extensions/filters/http/ext_proc/v3/processing_mode.proto ERROR: ./api/envoy/extensions/filters/http/ext_proc/v3/processing_mode.proto:125: over-enthusiastic spaces ERROR: From ./api/envoy/service/ext_proc/v3/external_processor.proto ERROR: ./api/envoy/service/ext_proc/v3/external_processor.proto:230: over-enthusiastic spaces ERROR: ./api/envoy/service/ext_proc/v3/external_processor.proto:233: over-enthusiastic spaces ``` I've removed the culprit extra-spaces from the proto. This was possibly caused by merging envoyproxy#38753 Risk Level: None. Only proto comment changes. Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: Sumit Kumar <sumitkmr@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Remove extra spaces from proto comments causing git-push failure.
Additional Description: After pulling latest main, git-push started failing with this error
I've removed the culprit extra-spaces from the proto. This was possibly caused by merging #38753
Risk Level: None. Only proto comment changes.
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]