Use circleci "gen2" image for linux-build step#27020
Open
sbc100 wants to merge 1 commit into
Open
Conversation
This is our more imporant build step because many others depend on it.
Collaborator
Author
|
I don't really see a significant speedup here. 24min for linux-build which is seems in the existing range. |
Member
|
In that case, maybe not worth it? Unless the cost is identical? |
Member
|
The cost is 20% more, so if there's no speedup at all it's not worth it. It might be worth doing 1-2 more test runs just to be sure. It might also be worth trying on some of the other builders too; maybe the extra single thread performance matters more on the browser or core0 test runner or something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is our more imporant build step because many others depend on it.