Use .exe launchers on windows by default#27017
Open
sbc100 wants to merge 1 commit into
Open
Conversation
dschuff
approved these changes
May 28, 2026
Member
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
LGTM but this needs a changelog entry, as users who are explicitly using the .bat or .ps1 will be broken by this change.
Now that we are building the exe launcher automatically in emscripten-releases its time to start trying it out for real. The old behaviour can be had by setting EM_USE_BAT_FILES when doing creating the launchers (normally during `./bootstrap`). See emscripten-core#24858
Collaborator
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are building the exe launcher automatically in emscripten-releases its time to start trying it out for real.
The old behaviour can be had by setting
EM_USE_BAT_FILESwhen creating the launchers (normally during./bootstrap).See #24858