Don't require proxy ip to use X-Forwarded-For header - #104
Open
ii8 wants to merge 1 commit into
Open
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing "--trusted-ip" option only allows setting a single IP meaning it does not work with multiple reverse proxies which is quite a common setup.
Furthermore it's not relevant that the proxy IP is trusted because as implemented in darkhttpd the first value from the
X-Forwarded-Forheader is used which is untrusted in any case. If you wanted a value from theX-Forwarded-Forheader(s) along with knowledge that it was put there by your own proxy you have to combine all the headers and parse values from the right, skipping only your own proxy IPs and taking the first from "outside". The first value from the left can be spoofed easily, it's ok here because we only use it for logging, but it's irrelevant whether the proxy ip is "trusted".Another benefit of this approach is that we don't have to compare IP addresses.
No release has been made with the --trusted-ip option so I'm assuming it's ok to make a breaking change like this