cleanup: drop dead forecast metadata leftovers and unused research barrel - #112
Merged
Merged
Conversation
…rrel Remove the unused registry method-definition helper, forecast.py passthroughs, forecast_methods wrapper, unused use-case constant re-exports, and the unused research package barrel. Live lookup and imports stay on the owning modules. Co-authored-by: Emerson Gomes <emerson.gomes@gmail.com>
Those monkeypatches targeted leftover imports that no longer exist on the wrapper module. Volatility routing still patches the volatility module maps it actually uses. Co-authored-by: Emerson Gomes <emerson.gomes@gmail.com>
emerzon
marked this pull request as ready for review
September 9, 2026 02:50
The first check still used a 50ms TTL, so loaded CI runners expired the row before the backdate ran. Use a 60s TTL and expire by rewriting updated_at. Co-authored-by: Emerson Gomes <emerson.gomes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove leftover forecast method-metadata passthroughs and unused research-capability barrels so one lookup path and one import path remain. No live caller behavior change.
What changed
forecast_registry._find_method_definitionand the test that only covered it. Live lookup stays inforecast_methods.py.core/web_api.pyandcore/forecast.pyatforecast_registry.get_forecast_methods_dataand dropped the unusedforecast.pyre-export plus unusedTIMEFRAME_MAP/TIMEFRAME_SECONDSimports.forecast_methods.get_forecast_methods_data()wrapper; snapshot/helpers call the registry alias directly.pretrained.pyand stalepretrained_refactored/forecast_moiraireferences intest_dry_optimization.py.forecast/use_cases/__init__.py(owning modules keep them).services/research/__init__.pybarrel. Callers already importCALENDAR/EQUITY_PROFILE/SCREENER/PERFORMANCEfromcapabilities.py.forecast.pytimeframe maps after those unused imports were removed.Left alone (verified on current
main, not guessed)PREFERRED_SOURCE_ORDER,NEWS, andRESEARCH_CAPABILITIESare already gone.forecast/optimize.pystill has one production importer (tune.py, lazy) and a direct test import (tests/forecast/test_optimize_hints.py). Collapsing it would move ~220 lines intotune.pyand change a tested import path, so it stayed put.CI follow-ups (not Area E leftovers)
TIMEFRAME_MAPpatches: fixed here.main; merged into this branch.main's backdate still used a 50ms TTL, so the firstcheckflaked on loaded runners. This branch now uses a 60s TTL and expires by rewritingupdated_at.Diff is deletions-first for Area E.