feat(frontend): upgrade dependencies and refactor Fiat Onramp Integration Interface#1239
Merged
Conversation
|
@Abidoyesimze is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
Replaces the hardcoded English copy added for the SEP-24 deposit modal (title, form labels, per-step loading messages, error fallback, iframe title) with next-intl translations under a new "fiatOnramp" namespace, translated for all three supported locales (en, es, pt). The dashboard's "Buy / Deposit" trigger button is localized too since it's part of the same feature surface. Closes emdevelopa#1212 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
FiatOnrampModal (deposit) and WithdrawalModal duplicated the same SEP-0001 discovery -> SEP-0010 auth -> SEP-0024 interactive-URL sequence almost line for line. Extracts useSep24AnchorFlow, a single hook that drives both directions and owns the CONNECTING/AUTH/SUBMITTING/READY state machine, and ports both modals onto it. WithdrawalModal's visible behavior is unchanged aside from gaining the same "connecting" loading state FiatOnrampModal already had, instead of a bare disabled button. Also bumps framer-motion (^12.41.0 -> ^12.42.2) and next-intl (^4.8.3 -> ^4.13.4), the two libraries this module depends on directly, both safe in-range updates verified against the full test suite. stellar-sdk and @stellar/freighter-api have major-version updates available (12->13, 1->6) but are used app-wide well beyond this module, so bumping them is out of scope here to avoid an unreviewed blast radius. Closes emdevelopa#1213 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Abidoyesimze
force-pushed
the
feature/fe-upgrade-dependencies-and-refactor-fiat-onramp-integration-interface
branch
from
July 24, 2026 20:12
84416e1 to
8058f22
Compare
|
@Abidoyesimze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FiatOnrampModal(deposit) and the existingWithdrawalModalduplicated the same SEP-0001 discovery -> SEP-0010 auth -> SEP-0024 interactive-URL sequence almost line for line. ExtractsuseSep24AnchorFlow, a single hook that drives both directions and owns theCONNECTING/AUTH/SUBMITTING/READYstate machine, and ports both modals onto it.WithdrawalModal's visible behavior is unchanged aside from gaining the same "connecting" loading stateFiatOnrampModalalready had (previously a bare disabled button during anchor discovery).framer-motion(^12.41.0 -> ^12.42.2) andnext-intl(^4.8.3 -> ^4.13.4) — the two libraries this module depends on directly, both safe in-range patch/minor bumps verified against the full test suite.stellar-sdkand@stellar/freighter-apialso have updates available, but they're major version jumps (12->13, 1->6) used app-wide well beyond this module — bumping them here would risk an unreviewed blast radius across unrelated payment flows, so left out of scope.Note: since this branch is built on top of the #1212 branch, this diff includes those commits until #1237 and #1238 merge — the "Files changed" tab will show only the refactor/upgrade-specific delta once they do.
Test plan
vitest run src/hooks/useSep24AnchorFlow.test.ts— 6/6 passing (idle state, deposit walk-through, withdrawal branch, unsupported-anchor error path, wallet-unavailable error path, reset)vitest run src/components/FiatOnrampModal.test.tsx— 7/7 passing after the refactortsc --noEmitclean on touched fileseslintclean on touched filesCloses #1213
🤖 Generated with Claude Code