Skip to content

fix(admin): sync TermFormDialog state on term change; add back button to Security & AllowedDomains settings #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pangerlkr wants to merge 10 commits into
base: main
Choose a base branch
from
+17 −1
Open

fix(admin): sync TermFormDialog state on term change; add back button to Security & AllowedDomains settings #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4ac7dce
Add PRD.md
Copilot Apr 4, 2026
49d027c
Merge pull request #1 from pangerlkr/copilot/create-prd-file
pangerlkr Apr 4, 2026
ae826b3
Merge branch 'main' into main
pangerlkr Apr 4, 2026
60ba3b9
fix(admin): sync TermFormDialog state on term change and add back but…
pangerlkr Apr 5, 2026
2d671de
Merge branch 'main' into fix/taxonomy-form-state-and-settings-back-bu…
pangerlkr Apr 5, 2026
8cc9f9d
Merge branch 'main' into fix/taxonomy-form-state-and-settings-back-bu…
pangerlkr Apr 8, 2026
bde8da4
Merge branch 'main' into fix/taxonomy-form-state-and-settings-back-bu…
pangerlkr Apr 9, 2026
d680328
docs(prd): update last-modified date to 2026-04-09
pangerlkr Apr 9, 2026
7a511d5
style: format
emdashbot[bot] Apr 9, 2026
efc5bdd
chore: remove PRD.md to resolve CLA co-authorship issue
pangerlkr Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/admin/src/components/TaxonomyManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ function TermFormDialog({
const [autoSlug, setAutoSlug] = React.useState(!term);
const [error, setError] = React.useState<string | null>(null);

// Sync form state when term prop changes (for edit mode)
// Sync form state when term prop changes (e.g. when editing a different term)
React.useEffect(() => {
setLabel(term?.label || "");
setSlug(term?.slug || "");
Expand Down
8 changes: 8 additions & 0 deletions packages/admin/src/components/settings/AllowedDomainsSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,14 @@ export function AllowedDomainsSettings() {

return (
<div className="space-y-6">
<div className="flex items-center gap-3">
<Link to="/settings">
<Button variant="ghost" shape="square" size="sm" aria-label="Back to Settings">
<ArrowLeft className="h-4 w-4" />
</Button>
</Link>
<h1 className="text-2xl font-bold">Self-Signup Domains</h1>
</div>
Comment on lines +227 to +234
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The back button is only present in the final render branch. The loading and error early-returns still render only an

(no back navigation), so users can still get stuck without an in-page way to return to /settings in those states. Consider reusing the same header JSX across all branches (loading, external-auth info, error, success).

Copilot uses AI. Check for mistakes.
{settingsHeader}

{/* Status message */}
Expand Down
8 changes: 8 additions & 0 deletions packages/admin/src/components/settings/SecuritySettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ export function SecuritySettings() {

return (
<div className="space-y-6">
<div className="flex items-center gap-3">
<Link to="/settings">
<Button variant="ghost" shape="square" size="sm" aria-label="Back to Settings">
<ArrowLeft className="h-4 w-4" />
</Button>
</Link>
<h1 className="text-2xl font-bold">Security Settings</h1>
</div>
Comment on lines +156 to +163
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new back button is only rendered in the main (non-loading / non-error) return path. In the loading and error early-returns, the header is still just an

with no back navigation, which reintroduces the same usability issue in those states. Consider extracting a shared header component/JSX and using it in all return branches (loading, external-auth info, error, and success) so navigation stays consistent.

Copilot uses AI. Check for mistakes.
{settingsHeader}

{/* Status message */}
Expand Down
Loading