fix(sqlite): Statement.run() and Database.exec() now return Changes object#1798
Closed
David Anderson (akapug) wants to merge 2 commits intoelide-dev:mainfrom
Closed
fix(sqlite): Statement.run() and Database.exec() now return Changes object#1798David Anderson (akapug) wants to merge 2 commits intoelide-dev:mainfrom
David Anderson (akapug) wants to merge 2 commits intoelide-dev:mainfrom
Conversation
…bject Previously, run() returned undefined and exec() returned Undefined.instance. Now both return a SQLiteChanges object with: - changes: number of affected rows - lastInsertRowid: rowid of the last inserted row This matches the Bun SQLite API behavior. Fixes elide-dev#1791
064997d to
8b529bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
Statement.run()andDatabase.exec()to return aChangesobject instead ofundefined, matching the Bun SQLite API.Problem
Per the TypeScript types and Bun compatibility,
run()andexec()should return aChangesobject:Previously:
Statement.run()returnedUnit(undefined in JS)Database.exec()returnedUndefined.instanceSolution
SQLiteChangesinterface - Defines the contract matching Bun'sChangesSQLiteChangesImpl- Internal implementation as aProxyObjectfor JS interopexec()- Now captures update count and last insert rowid from JDBCrun()- Returns the result fromexec()Changes
SQLiteChanges.ktSQLiteStatement.ktrun()returnsSQLiteChangesSQLiteDatabase.ktexec()returnsSQLiteChangesSqliteModule.ktUsage
Fixes
Fixes #1791