Skip to content

WIP: create a new room when inviting people in a DM#6756

Draft
jmartinesp wants to merge 5 commits intomisc/adapt-to-is-dm-changesfrom
feat/create-room-when-inviting-people-in-dm
Draft

WIP: create a new room when inviting people in a DM#6756
jmartinesp wants to merge 5 commits intomisc/adapt-to-is-dm-changesfrom
feat/create-room-when-inviting-people-in-dm

Conversation

@jmartinesp
Copy link
Copy Markdown
Member

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp added PR-Wip For anything that isn't ready to ship and will be enabled at a later date Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels May 8, 2026
@github-actions github-actions Bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 8, 2026
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 8, 2026
@github-actions github-actions Bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YbJ2ry

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.23%. Comparing base (269b4f3) to head (288430a).

Files with missing lines Patch % Lines
.../invitepeople/impl/DefaultInvitePeoplePresenter.kt 83.33% 3 Missing and 1 partial ⚠️
...id/features/invitepeople/api/InvitePeopleEvents.kt 0.00% 1 Missing ⚠️
...droid/features/roomdetails/impl/RoomDetailsView.kt 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           misc/adapt-to-is-dm-changes    #6756   +/-   ##
============================================================
  Coverage                        81.22%   81.23%           
============================================================
  Files                             2633     2633           
  Lines                            73488    73526   +38     
  Branches                          9495     9499    +4     
============================================================
+ Hits                             59694    59728   +34     
- Misses                           10301    10304    +3     
- Partials                          3493     3494    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Wip For anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants