Skip to content

Don't compress images sent through the Files attachment picker#6755

Open
cizra wants to merge 1 commit intoelement-hq:developfrom
cizra:send-file-orig-quality
Open

Don't compress images sent through the Files attachment picker#6755
cizra wants to merge 1 commit intoelement-hq:developfrom
cizra:send-file-orig-quality

Conversation

@cizra
Copy link
Copy Markdown

@cizra cizra commented May 8, 2026

Content

Don't compress images sent through the Files attachment picker

Motivation and context

Images and videos picked through the "Attachment" picker are now uploaded without re-encoding, regardless of the "Optimize media quality" setting. The gallery and camera pickers keep the existing behaviour, matching what Element Web/Desktop and most other messengers do.

Fixes #6365

Screenshots / GIFs

Tests

Manual test:

  • built baseline APK and installed in phone
  • Media optimization is enabled. Sent a photo as media, and as a file.
    • Both got resized.
  • built APK from this branch and installed in phone
  • Media optimization is still enabled. Sent a photo as media, and as a file.
    • Photo got resized, file retained original quality (visually - much smaller details are visible. I did not check byte equality)

Tested devices

  • Physical
  • Emulator
  • OS version(s): LineageOS 22

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
    • Tested on Android device: yes. Not sure about API 42.
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

Images and videos picked through the "Attachment" picker are now
uploaded without re-encoding, regardless of the "Optimize media quality"
setting. The gallery and camera pickers keep the existing behaviour,
matching what Element Web/Desktop and most other messengers do.

Fixes element-hq#6365
@cizra cizra requested a review from a team as a code owner May 8, 2026 08:17
@cizra cizra requested review from jmartinesp and removed request for a team May 8, 2026 08:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • If your pull request adds a feature or modifies the UI, this should have an equivalent pull request in the Element X iOS repo unless it only affects an Android-only behaviour or is behind a disabled feature flag, since we need parity in both clients to consider a feature done. It will also need to be approved by our product and design teams before being merged, so it's usually a good idea to discuss the changes in a Github issue first and then start working on them once the approach has been validated.
  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@github-actions github-actions Bot added the Z-Community-PR Issue is solved by a community member's PR label May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sending attachment photo sends the photo resized and compressed

2 participants