Render media captions formatting in the media viewer#6729
Render media captions formatting in the media viewer#6729jmartinesp merged 4 commits intoelement-hq:developfrom
Conversation
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
7d51a4d to
9fd3f13
Compare
jmartinesp
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I think the PR needs some more work, if you were using an AI agent I think it got some things wrong about the current setup 😅 .
2cbd345 to
fab1f2d
Compare
bxdxnn
left a comment
There was a problem hiding this comment.
Yes, sorry, this PR was vibecoded as there were some weird bugs that I wasn't able to solve because of media viewer flickering, but as I've fixed the media viewer this PR started to work automatically. I'll resolve the code smell manually.
2729f1b to
2e58349
Compare
2e58349 to
887f37b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6729 +/- ##
========================================
Coverage 81.23% 81.23%
========================================
Files 2628 2628
Lines 73334 73424 +90
Branches 9484 9493 +9
========================================
+ Hits 59572 59649 +77
- Misses 10269 10277 +8
- Partials 3493 3498 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm uploading a few quick fixes that should unblock this. |
Content
Motivation and context
Fixes #6506
Screenshots / GIFs
Tests
Tested devices
Checklist