Skip to content

Remove SignInWithClassic FeatureFlag to enable the feature.#6698

Draft
bmarty wants to merge 1 commit intodevelopfrom
feature/bma/enableSigninWithClassic
Draft

Remove SignInWithClassic FeatureFlag to enable the feature.#6698
bmarty wants to merge 1 commit intodevelopfrom
feature/bma/enableSigninWithClassic

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Apr 30, 2026

Closes #6669

Draft, as we do not want to merge it now. But it can be reviewed, so we are ready to merge whenever we want.

@bmarty bmarty added the PR-Feature For a new feature label Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/r3T3Nx

@sonarqubecloud
Copy link
Copy Markdown

@ElementBot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️

features/login/impl/src/main/kotlin/io/element/android/features/login/impl/classic/ElementClassicConnection.kt#L206 - This Handler class should be static or leaks might occur (io.element.android.features.login.impl.classic.DefaultElementClassicConnection.IncomingHandler)

Generated by 🚫 dangerJS against fabdcee

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.35%. Comparing base (8b8eedb) to head (fabdcee).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6698   +/-   ##
========================================
  Coverage    81.35%   81.35%           
========================================
  Files         2630     2630           
  Lines        73372    73360   -12     
  Branches      9517     9515    -2     
========================================
- Hits         59689    59680    -9     
+ Misses       10180    10178    -2     
+ Partials      3503     3502    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty
Copy link
Copy Markdown
Member Author

bmarty commented May 7, 2026

Note: we will include this on EXA 26.05.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Feature For a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Enable SignInWithClassic by default

2 participants