Skip to content

fix: fix import locations for automation scripts#2634

Merged
taylor-swanson merged 3 commits intoelastic:mainfrom
taylor-swanson:fix/automation-imports
May 5, 2026
Merged

fix: fix import locations for automation scripts#2634
taylor-swanson merged 3 commits intoelastic:mainfrom
taylor-swanson:fix/automation-imports

Conversation

@taylor-swanson
Copy link
Copy Markdown
Contributor

  • fix import locations for automation scripts to fix ModuleNotFound errors.

@taylor-swanson taylor-swanson requested a review from a team as a code owner May 5, 2026 17:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

ECS PR Triage (automated)

PR Triage Report

PR: #2634 — fix: fix import locations for automation scripts
Classification: Direct PR
Change type: Tooling
Scope: Minor

Summary

This PR moves inline from release_automation.changelog import ... and from release_automation.release_notes import ... statements from inside functions to top-of-file imports in two release automation scripts (run_ff.py and run_prep.py). The change fixes ModuleNotFoundError runtime failures. This is a straightforward bugfix confined to release automation tooling with no schema, documentation, or RFC implications.

Files changed

  • Schemas: none
  • Generated: none (not expected — no schema changes)
  • Tooling/scripts/tests: scripts/release_automation/run_ff.py, scripts/release_automation/run_prep.py
  • Docs (hand-authored): none
  • CI / GitHub: none
  • RFCs: none

Routing decision

Direct PR is appropriate. Per classification-rules §2, this is a "Tooling only" change — modifications are limited to scripts/ files, specifically release automation helpers. No schemas/ files are touched, no new fields are introduced, and no breaking or semantic changes are present. The change is a pure bugfix (correcting import locations to resolve ModuleNotFoundError), which falls squarely under the "Bugfix / clarity" pattern in §2.

No RFC triggers from §1 apply:

  • No new top-level field set.
  • No breaking changes.
  • No new reuse topology.
  • No novel use case.
  • No ECS-wide scope.
  • No new leaf fields.

Risk notes

  • Breaking / deprecation: No. The change preserves identical runtime behavior — the same functions are imported, just at module load time instead of inline within function bodies.
  • OTel / semconv: N/A — no schema or field changes.
  • Scope / reuse: N/A — no fieldset, reuse, or categorization changes.

Completeness checklist

  • PR description (all sections)Missing. The PR body is a single sentence ("fix import locations for automation scripts to fix ModuleNotFound errors.") and does not fill out the 7 template sections from .github/PULL_REQUEST_TEMPLATE.md. Sections 1–7 (what, fields affected, why, docs, built ECS, tests, reviewer notes) are not addressed. Remediation: Fill out the PR template sections. For a minor tooling bugfix, brief answers (e.g., "N/A" for fields affected, "NO" for built ECS since no schema changes) are sufficient.
  • CHANGELOG.next.mdNot strictly required for internal release automation tooling. While scripts/ changes normally warrant a changelog entry under "Tooling and Artifact Changes," release automation scripts are internal infrastructure not shipped as ECS artifacts. A changelog entry would be a nice-to-have but is not critical. If desired: add an entry under "Tooling and Artifact Changes > Bugfixes" with #2634.
  • make + committed generated outputs — N/A (no schema changes; no generated output expected).
  • OTel otel: on new/changed semconv-related fields — N/A (no field changes).
  • Tests / make check — Not directly verifiable from the diff. The release automation scripts do not appear to have dedicated unit tests in the diff. The import fix is straightforward and low-risk. Recommendation: confirm python -c "from release_automation.run_ff import main; from release_automation.run_prep import main" succeeds.
  • CLA (contributor) — Author (taylor-swanson) is an Elastic employee; CLA is expected to be in place.

Recommended next actions

  1. Contributor: Fill out the PR description template — even brief answers for each section help reviewers and future archaeology.
  2. Contributor (optional): Add a CHANGELOG.next.md entry under "Tooling and Artifact Changes > Bugfixes" referencing #2634, if the team tracks release automation fixes in the changelog.
  3. Maintainer: Review and merge — this is a low-risk, self-contained bugfix to internal tooling. Verify the import paths resolve correctly in the release automation environment.

Posted by PR Triage workflow

@taylor-swanson taylor-swanson merged commit f8bc42b into elastic:main May 5, 2026
7 checks passed
@taylor-swanson taylor-swanson deleted the fix/automation-imports branch May 5, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants