Skip to content

Add docker layer caching for docker builds#2270

Closed
reakaleek wants to merge 3 commits intomainfrom
feature/add-docker-layer-caching
Closed

Add docker layer caching for docker builds#2270
reakaleek wants to merge 3 commits intomainfrom
feature/add-docker-layer-caching

Conversation

@reakaleek
Copy link
Copy Markdown
Member

@reakaleek reakaleek commented Nov 25, 2025

No description provided.

@reakaleek reakaleek added the automation packaging, ci/cd. label Nov 25, 2025
@reakaleek reakaleek self-assigned this Nov 25, 2025
@reakaleek reakaleek marked this pull request as ready for review November 25, 2025 09:40
@reakaleek reakaleek requested a review from a team as a code owner November 25, 2025 09:40
@reakaleek reakaleek requested a review from cotti November 25, 2025 09:40
Mpdreamz
Mpdreamz approved these changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me mind giving the PR description as to why these changes are necessary?

I've read https://docs.docker.com/build/ci/github-actions/cache/#github-cache and understand what it does not super clear on all the benefits. Is this to speed up the build? A lot of time is simply the AOT publish maybe?

The default max cache size is 10GB so no qualms there.

@reakaleek
Copy link
Copy Markdown
Member Author

reakaleek commented Nov 25, 2025

Changes look good to me mind giving the PR description as to why these changes are necessary?

I've read https://docs.docker.com/build/ci/github-actions/cache/#github-cache and understand what it does not super clear on all the benefits. Is this to speed up the build? A lot of time is simply the AOT publish maybe?

The default max cache size is 10GB so no qualms there.

It looks like the caching made the build even slower. 😅

The main reason why I created this PR was because I saw the dotnet_install script failing again in a release workflow and I thought this could be cached to make it more resilient

@reakaleek reakaleek marked this pull request as draft November 25, 2025 10:51
Mpdreamz
Mpdreamz requested changes Nov 26, 2025
View reviewed changes
Comment thread src/api/Elastic.Documentation.Api.Lambda/Dockerfile
dnf install -y npm git clang tar findutils && \
dnf clean all

# Install .NET SDK based on global.json version
Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave in the comment that this might be temporary:

amazonlinux/amazon-linux-2023#1025

@reakaleek
Copy link
Copy Markdown
Member Author

reakaleek commented Jan 7, 2026

Closing, the problem I tried to solve didn't happen since I opened this PR.

@reakaleek reakaleek closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mpdreamz Mpdreamz Mpdreamz requested changes

@cotti cotti Awaiting requested review from cotti cotti is a code owner automatically assigned from elastic/docs-engineering

Assignees

@reakaleek reakaleek

Labels

automation packaging, ci/cd.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reakaleek @Mpdreamz