Force share password via server config#1820
Open
aetasoul wants to merge 6 commits into
Open
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Server side enforcement in OShare.create() via new checkPasswordRequired check on UploadResult. Config flag `require-share-password` (default false) exposed through AppConfig to the frontend. Frontend guards: Share page blocks submit without password Detail page blocks clearing password when flag is on DELETE /sec/share/:id/password returns 400 when flag is on
aetasoul
force-pushed
the
feat/force-pass-1777
branch
from
7d5993f to
4bd9c2f
Compare
Master's PT-BR translation predates require-share-password, leaving `br` Texts records incomplete for passwordCannotBeRemoved (DetailPage) and passwordRequiredToCreate (SharePage). No textual git conflict on merge, but Elm compile failed CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #1777
When
sharry.restserver.backend.share.require-share-password = true, authenticated users must set a password on every share they create.DELETE /sec/share/:id/passwordreturns an error instead of removing the passwordChanges
ShareConfig: newrequireSharePassword: Booleanflag (defaultfalse)UploadResult: newcheckPasswordRequiredcheck, chained aftercheckValidityOShare.create: applies the check before inserting the shareShareRoutes:DELETE /:id/passwordguarded by the flagInfoRoutes/AppConfig:sharePasswordRequiredexposed viaGET /api/v2/open/info/appconfigso the frontend can adaptpasswordValidationErrorstate added to Share and Detail pages;passwordRequiredToCreateandpasswordCannotBeRemovedmessages added in all 8 supported languagesreference.conf,configure.md,webapp.md,sharry-openapi.yml: documentation