-
Notifications
You must be signed in to change notification settings - Fork 11
[Snyk] Security upgrade koa from 2.16.2 to 3.0.1 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atian25
wants to merge
1
commit into
master
Choose a base branch
from
snyk-fix-c37c927ad06e12282e9b83720b239b4c
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request upgrades
koafrom av2.xrelease tov3.0.1. This is a major version bump which introduces significant breaking changes and a critical compatibility issue with other dependencies in this project.egg1,egg2, andegg3packages listed in yourdevDependencieshave a peer dependency on[email protected]. For example,[email protected]requireskoa: '^2.5.0'.koatov3.0.1violates this peer dependency requirement. This will almost certainly causenpm installto fail or lead to unexpected runtime errors in theegg-based applications within this repository.Recommendation:
Before this change can be merged, the
eggdependencies must be updated to versions that are compatible withkoa@3. If compatible versions are not available, this upgrade cannot be performed without breaking theegg-related parts of your project.