Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"egg1": "^1.11.0",
"egg2": "^2.37.0",
"egg3": "^3.3.3",
"koa": "^2.13.4",
"koa": "^3.0.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This pull request upgrades koa from a v2.x release to v3.0.1. This is a major version bump which introduces significant breaking changes and a critical compatibility issue with other dependencies in this project.

  • Peer Dependency Conflict: The egg1, egg2, and egg3 packages listed in your devDependencies have a peer dependency on [email protected]. For example, [email protected] requires koa: '^2.5.0'.
  • Build/Runtime Failure: Upgrading koa to v3.0.1 violates this peer dependency requirement. This will almost certainly cause npm install to fail or lead to unexpected runtime errors in the egg-based applications within this repository.

Recommendation:
Before this change can be merged, the egg dependencies must be updated to versions that are compatible with koa@3. If compatible versions are not available, this upgrade cannot be performed without breaking the egg-related parts of your project.

"koa-router": "^12.0.0",
"nunjucks": "^3.0.1"
},
Expand Down