Add GNU/Hurd support#1918
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2168fc0ac5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Minix) | ||
| WEIRD_OS="no" | ||
| ;; | ||
| GNU) |
There was a problem hiding this comment.
Regenerate configure for GNU/Hurd support
This new GNU) branch is only added to aclocal.m4, but the checked-in top-level configure script was not regenerated and still has no corresponding GNU) cases. Since users and CI invoke ./configure directly, GNU/Hurd builds will continue to take the old fallback path (WEIRD_OS=yes and default shared-library flags) unless they manually run autotools first; the repo's .github/workflows/misc.yml autotools check also runs misc/runautotools and fails on any resulting diff.
Useful? React with 👍 / 👎.
Found by: me
Patch by: me
One-line summary: If Minix and Haiku are not "weird", GNU/Hurd isn't either
Test cases demonstrating functionality (if applicable):
This small fix is applied in the Debian package and it builds fine now https://buildd.debian.org/status/logs.php?pkg=eggdrop&arch=hurd-i386