Share encryption2.mod (pbkdf2.mod) settings#1735
Open
michaelortmann wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes: #1657
One-line summary:
Share encryption2.mod (pbkdf2.mod) settings
Additional description (if needed):
If share bots have different pbkdf2 settings, they will constantly rehash shared passwords and reshare the new hashed passwords, when a user logs in. it would be best to have the same settings in each of the share bots config files. This PR lets share hubs share their setting, so that leaf bots can override their (different) config setting with the settings they received from the hub and also log a hint to adapt the config file proper.
Test cases demonstrating functionality (if applicable):