Skip to content

feat: get secret in encrypt_secret management command via getpass (prompt) instead of argument#1

Merged
efe merged 4 commits intomainfrom
improvements-encrypt_secret-management-command
Mar 21, 2026
Merged

feat: get secret in encrypt_secret management command via getpass (prompt) instead of argument#1
efe merged 4 commits intomainfrom
improvements-encrypt_secret-management-command

Conversation

@efe
Copy link
Copy Markdown
Owner

@efe efe commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively removes a problem of having secrets accidentally end up in shell histories by design, so this is very much a welcome choice ❤️

I don't think that it costs a lot in UX, neither.

Comment thread README.md Outdated
efe and others added 3 commits March 21, 2026 10:25
@efe efe changed the title feat: get secret key via getpass feat: get secret key via getpass (prompt) instead of argument Mar 21, 2026
@efe efe changed the title feat: get secret key via getpass (prompt) instead of argument feat: get secret in encrypt_secret management command via getpass (prompt) instead of argument Mar 21, 2026
@efe efe merged commit 375afa0 into main Mar 21, 2026
1 check passed
@efe
Copy link
Copy Markdown
Owner Author

efe commented Mar 21, 2026

Many thanks, @benjaoming. Really grateful for your input!

@efe efe deleted the improvements-encrypt_secret-management-command branch March 21, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants