feat: route Insights video APIs through Snowflake - #214
Merged
santhosh-apphelix-2u merged 4 commits intoSep 3, 2026
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
naincy128
approved these changes
Sep 3, 2026
There was a problem hiding this comment.
🟡 Changes recommended
There are correctness issues that can cause failures in Snowflake row mapping (NULL integer handling) and in test cleanup logic (thread-local DB hint fallback can point to a non-existent DB alias).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Migrates the Insights video engagement endpoints to optionally read from Snowflake (behind the global insights_snowflake_enabled Waffle flag) while preserving existing response shapes and adding an X-Insights-Data-Source response header indicating Aurora vs Snowflake.
Changes:
- Added Snowflake query + mapping + service layers for course videos and video timeline endpoints.
- Updated existing course/videos and video/timeline views to route through Snowflake only when the global flag is enabled (otherwise defaulting to Aurora).
- Added unit tests covering query construction, mapping, service orchestration, data-source headers, and empty-result 404 behavior.
File summaries
| File | Description |
|---|---|
| analytics_data_api/v0/views/videos.py | Routes videos/{video_id}/timeline/ through Snowflake when enabled and sets data-source response header. |
| analytics_data_api/v0/views/courses.py | Routes courses/{course_id}/videos/ through Snowflake when enabled and sets data-source response header. |
| analytics_data_api/v0/tests/views/test_videos.py | Adds view-level tests for Snowflake/Aurora routing, headers, and empty-result 404 behavior. |
| analytics_data_api/v0/tests/views/test_courses.py | Adds view-level tests for Snowflake/Aurora routing, headers, and empty-result 404 behavior. |
| analytics_data_api/tests/test_insights_snowflake.py | Adds tests for Snowflake video query SQL, mappers, and service orchestration. |
| analytics_data_api/insights_snowflake/service.py | Adds service functions to orchestrate video queries and mapping. |
| analytics_data_api/insights_snowflake/queries/videos.py | Introduces Snowflake SQL query helpers for course videos and video timeline data. |
| analytics_data_api/insights_snowflake/mappers/videos.py | Introduces Snowflake row-to-API-shape mappers for video and timeline data. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+38
to
+41
| value = _row_value(row, name) | ||
| if name in INTEGER_FIELDS: | ||
| return int(value) | ||
| return value |
Comment on lines
+1018
to
+1020
| def tearDown(self): | ||
| thread_data.analyticsapi_database = getattr(settings, 'ANALYTICS_DATABASE', 'analytics') | ||
| super().tearDown() |
Comment on lines
+16
to
+18
| def tearDown(self): | ||
| thread_data.analyticsapi_database = getattr(settings, 'ANALYTICS_DATABASE', 'analytics') | ||
| super().tearDown() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the Insights video engagement APIs to support Snowflake reads behind the global
insights_snowflake_enabledWaffle flag.This covers:
GET /api/v1/courses/{course_id}/videos/GET /api/v1/videos/{video_id}/timeline/Aurora remains the default path when the flag is off.
Changes
VIDEOandVIDEO_TIMELINE.