-
-
Notifications
You must be signed in to change notification settings - Fork 35
fix Gemini tool calling #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+339
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Normalizes ECA’s interleaved tool history into OpenAI/Gemini-compatible turns: all parallel tool_calls first, then all tool outputs, without merging sequential tool-loop rounds (uses :tool-turn-id boundaries). - Preserves Gemini extra_content.google.thought_signature across turns (stored as :external-id and emitted back on tool_calls), preventing 400 INVALID_ARGUMENT on Gemini 3 Flash tool calls. - Makes streamed tool execution deterministic even when providers omit tool_calls[].index (fallback :stream-order) and avoids tool-loop stalls on invalid JSON tool arguments. - Adds unit tests covering ordering, tool-turn boundaries, thought_signature preservation, and deterministic execution.
4f97ff0 to
ad33856
Compare
ericdallo
approved these changes
Jan 12, 2026
Member
ericdallo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
|
Hmm /init still fails: with: it looks like its the latest binary: |
Member
Author
Member
|
@zikajk does |
Member
Author
|
@ericdallo It doesn't :-(. Interesting... |
Member
Author
|
I will try to take a look soon why is that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Normalizes ECA’s interleaved tool history into OpenAI/Gemini-compatible turns: all parallel tool_calls first, then all tool outputs, without merging sequential tool-loop rounds (uses :tool-turn-id boundaries).
Preserves Gemini extra_content.google.thought_signature across turns (stored as :external-id and emitted back on tool_calls), preventing 400 INVALID_ARGUMENT on Gemini 3 Flash tool calls.
Makes streamed tool execution deterministic even when providers omit tool_calls[].index (fallback :stream-order) and avoids tool-loop stalls on invalid JSON tool arguments.
Adds unit tests covering ordering, tool-turn boundaries, thought_signature preservation, and deterministic execution.
I added a entry in changelog under unreleased section.