Add client for interacting with the public dataset registry#20
Merged
Conversation
Add comprehensive Registry API client for dataset discovery, search, and publishing. The Registry is an external service for storing and sharing dataset manifests. Components: - RegistryClient: HTTP client with authentication support - RegistryDatasetsClient: Dataset operations (read/write) - Custom error handling with error code mapping - Pydantic models generated from OpenAPI spec - Custom datetime validators for API timestamp format Key features: - Dataset search (full-text and AI semantic) - Dataset browsing and version management - Manifest fetching - Publishing capabilities (requires auth) - Metadata management The API returns timestamps in 'YYYY-MM-DD HH:MM:SS.ffffff UTC' format, requiring custom validators for Pydantic datetime parsing. Files: - src/amp/registry/client.py: Main Registry client - src/amp/registry/datasets.py: Dataset operations - src/amp/registry/models.py: Auto-generated Pydantic models - src/amp/registry/errors.py: Error handling - src/amp/registry/validators.py: Custom datetime parsing - pyproject.toml: Exclude generated models from linting
- AdminClient: Pass auth=True or auth_token directly (was duplicating the if/elif/else chain) - RegistryClient: Use get_token() callable for current token value
Update RegistryClient to support the same auth patterns as AdminClient
JohnSwan1503
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a registry client for interacting with the public registry.
Supported functionality:
Example usage: