Skip to content

Conversation

@bleggett
Copy link
Contributor

@bleggett bleggett commented Jan 28, 2026

Now that the cargo publish/release-plz flow is in place, we don't need to (and cannot) "publish" on PR runs.

This fixes spurious CI publish failures on PRs like:
#56

This fixes spurious publish failures like:
edera-dev#56
@bleggett bleggett requested review from found-it and kaniini January 28, 2026 17:02
@found-it
Copy link
Contributor

Good catch @bleggett, the idea here was that we run the workflow and build the styrolite artifacts then upload them to the workflow run in case anyone wants to download them. Rather than not running on PR, we should just use an if conditional to only generate a token and publish (last two jobs) on release events.

@bleggett
Copy link
Contributor Author

Good catch @bleggett, the idea here was that we run the workflow and build the styrolite artifacts then upload them to the workflow run in case anyone wants to download them. Rather than not running on PR, we should just use an if conditional to only generate a token and publish (last two jobs) on release events.

Yep, that's better. I missed the artifact upload would still happen even on PRs.

@bleggett bleggett changed the title We no longer actually publish on PR runs Don't try to generate cultivator token on PR runs Jan 28, 2026
@bleggett bleggett merged commit a40d315 into edera-dev:main Jan 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants