Skip to content

[MARSC-385] Force levtype to surface for wave data #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tbkr wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[MARSC-385] Force levtype to surface for wave data #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c43e77
bug: Force levtype to surface for wave data
tbkr Jun 1, 2026
70aa31e
feat: Add regression test files
tbkr Jun 1, 2026
74dc852
MARSC-385 moved levtype=sfc for wave streams in language (from modifi…
danovaro Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion share/metkit/language.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,12 @@ _field: &_field
category: data
aliases: [levtyp]
defaults:
- vals: [pl]
- context:
stream: ['!', dacw, dcwv, ewda, ewhc, ewla, ewmm, ewmo, lwwv, mawm, mawv, mfaw, mfhw, mfwm, mhwm, mnfw, mswm, scwv, swmm, waef, wamd, wamf, wamo, wams, wasf, wave, weef, weeh, wees, wehs, weov, wmfm, wvhc]
vals: [pl]
- context:
stream: [dacw, dcwv, ewda, ewhc, ewla, ewmm, ewmo, lwwv, mawm, mawv, mfaw, mfhw, mfwm, mhwm, mnfw, mswm, scwv, swmm, waef, wamd, wamf, wamo, wams, wasf, wave, weef, weeh, wees, wehs, weov, wmfm, wvhc]
vals: [sfc]
flatten: false
type: [enum, integer]
values:
Expand Down
1 change: 0 additions & 1 deletion share/metkit/modifiers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
stream: [ssmi]
unset: [levtype, levelist, param, grid, rotation]

# new default for levtype=ml, to be enabled later
- context:
levtype: [ml]
defaults:
Expand Down
18 changes: 18 additions & 0 deletions tests/expand/MARSC-385.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
RETRIEVE,
CLASS = OD,
TYPE = PF,
STREAM = WAEF,
EXPVER = 0001,
REPRES = SH,
LEVTYPE = SFC,
PARAM = 140229/140232/140245,
DATE = 20201101,
TIME = 0000/0600/1200/1800,
STEP = 9,
NUMBER = 1,
DOMAIN = G,
TARGET = reference.0GhkzD.data,
RESOL = AUTO,
AREA = 39.5/140/39.5/140,
GRID = .1/.1,
PADDING = 0
14 changes: 14 additions & 0 deletions tests/expand/MARSC-385.req
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
retrieve,
area=39.5/140/39.5/140,
class=od,
date=20201101,
expver=1,
grid=0.1/0.1,
number=1,
padding=0,
param=229.140/232.140/245.140,
step=9,
stream=waef,
time=00/06/12/18,
type=pf,
target=reference.0GhkzD.data
Loading