Improve shallow clone#148
Merged
Merged
Conversation
marcosbento
force-pushed
the
feature/shallow-clone-improvements
branch
4 times, most recently
from
33556e0 to
76e9e24
Compare
For correct handling on submodules, the option needs to be provided globally. In order to not pollute the CI environment, a temporary HOME is used to deploy a .gitconfig.
marcosbento
force-pushed
the
feature/shallow-clone-improvements
branch
from
76e9e24 to
df72cbb
Compare
mcakircali
approved these changes
Jun 3, 2026
mcakircali
left a comment
mcakircali
left a comment
Contributor
There was a problem hiding this comment.
looks good to me. just be sure of the change from warn to critical.
| endif() | ||
|
|
||
| if( _PAR_UPDATE AND _PAR_SHALLOW ) | ||
| ecbuild_warn("UPDATE and SHALLOW conflict — shallow clones aren't switchable; UPDATE may be ignored or fail.") |
Contributor
There was a problem hiding this comment.
ecbuild_critical fails? if yes, this changes the behavior, not just a log change as in PR desc. if it's intentional, it's fine.
Collaborator
Author
There was a problem hiding this comment.
Hi.
I was just following the documentation above, which stated: SHALLOW is not switchable and will fail if UPDATE is requested on an existing shallow clone.
Given the inconsistency between implementation and documentation, I decided to err on the side of caution and fail clearly and as early as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add more and improve existing tests, improve documentation, and improve debug/info message...
Contributor Declaration
By opening this pull request, I affirm the following: