Skip to content

Improve onboarding documentation#2874

Merged
antonkri merged 1 commit into
mainfrom
ankr_improve_onboarding_doc
May 26, 2026
Merged

Improve onboarding documentation#2874
antonkri merged 1 commit into
mainfrom
ankr_improve_onboarding_doc

Conversation

@antonkri
Copy link
Copy Markdown
Contributor

@antonkri antonkri commented May 6, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

⚠️ Docs-as-Code version mismatch detected
Please check the CI build logs for details and align the documentation version with the Bazel dependency.

Comment thread docs/_assets/css/score_handbook.css Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright 2026?

Comment thread docs/_assets/js/toc_collapse.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright 2026?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright 2026?

@antonkri antonkri force-pushed the ankr_improve_onboarding_doc branch from f3d1407 to c0ddd6e Compare May 6, 2026 08:32
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

The created documentation from the pull request is available at: docu-html

@antonkri antonkri force-pushed the ankr_improve_onboarding_doc branch from c0ddd6e to 854c668 Compare May 6, 2026 11:51
Copy link
Copy Markdown
Contributor

@PandaeDo PandaeDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments from my side. Improvement of the onboarding is very helpful!

Comment thread docs/_assets/css/score_handbook.css Outdated
* *******************************************************************************
*
* Overrides the default purple S-CORE secondary color (#2D1942).
* --pst-color-secondary is used for the page header, card headers, table hover, etc.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where. But it seems to me that the handbook is not correctly integrated into the page. I have a purple line in between Eclipse S-CORE and Features. Also under that after the home symbol i have . And the only way to reach the slides is the navigation on the right sight. Maybe only rendered wrong on my side. So please check it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, can not see any more entry point for handbook

Comment thread docs/index.rst Outdated
^^^
Our release roadmap can be found under :ref:`releases`.
Including an overview about integrated software modules and their repository location.
Check out our `latest release <https://eclipse-score.github.io/reference_integration/main/_collections/score_platform/docs/score_releases/score_releases/score_v0_6.html>`_
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use this link it will allways have the latest version on top https://github.com/eclipse-score/reference_integration/releases. Or if you want to show the html format https://eclipse-score.github.io/reference_integration/main/.

Comment thread docs/index.rst Outdated
and without direct customer value — S-CORE provides a common foundation with:

- **A reference implementation** that catches integration issues early and prevents known bugs from reappearing across projects.
- **A Functional-Safety-compliant process** (ISO 26262) applied to all modules, making S-CORE unique among open-source automotive projects.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not 100% when we say it will be applied to all modules. You might change it in a way that S-CORE includes a process based on ISO 26262 SEooC approach that is "ready the be certifiable" and it will applied by all modules that will contain in 1.0 release.

@antonkri antonkri force-pushed the ankr_improve_onboarding_doc branch 3 times, most recently from 00bf575 to 4485970 Compare May 10, 2026 15:31
@antonkri antonkri force-pushed the ankr_improve_onboarding_doc branch from 9c0d235 to 82bc924 Compare May 10, 2026 19:09
Copy link
Copy Markdown
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview is still missing in the Start/Landing Page, only available as card, but not top level entry

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System verification -> Platform or SW Platform Verification

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the overview.
I would suggest the following improvements:

  • Unit Verification
    • Please add Rust Test as an alternative
  • Component / Feature Verification
    • Please add GoogleTest and Rust Test as an alternative.
      In case the component is a library this should be sufficient for most test cases. For non-functional tests and later security tests ITF will probably get mandatory
  • Feature Verification
    • Please remove (ITF) from blue box.

Comment thread docs/_assets/css/score.css Outdated
--pst-color-text-base: #ffffff;
--pst-color-link: #ffffff;
--pst-color-link-hover: #ffffff;
color: #ffffff !important;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important is bad practise as it destroys the layout

@antonkri antonkri force-pushed the ankr_improve_onboarding_doc branch 4 times, most recently from a2d81ae to 3ddd051 Compare May 15, 2026 08:17
.. toctree::
:maxdepth: 1
:glob:

Please note that the Eclipse S-CORE´s software architecture is continuously refined and will evolve in future releases.

.. image:: ../../modules/_assets/module_architecture.drawio.svg
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have different mismatching architectural views: https://eclipse-score.github.io/score/pr-2874/_images/architecture_0_6.drawio.svg and the used link https://eclipse-score.github.io/score/pr-2874/_images/module_architecture.drawio.svg

a) we have to consolidate
b) for the purpose here, I would suggest to use the building block architectural view as in https://eclipse-score.github.io/score/pr-2874/_images/architecture_0_6.drawio.svg

Comment thread docs/_assets/css/score.css Outdated
html body .score-grid .sd-card .sd-card-body a:hover,
html body .score-grid .sd-card .sd-card-body a:visited,
html body .score-grid .sd-card .sd-card-body * {
color: #ffffff !important;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout rules shall not be overwritten

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only cpp covered?
approval comments help, but 2nd source to process description: double maintenance issue!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really follow the module=one repository approach?

@@ -169,13 +173,14 @@ Here, we´re making the first declaration of our module by defining a name and a
Please be aware, that only after our module was published in the Eclipse S-CORE bazel registry, other modules can access it.

Rename the module and replace *cpp_rust_template_repository* by *score_scrample*.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

score/<module_name instead scrample ?

Comment thread docs/contribute/general/naming.rst Outdated
..
# *******************************************************************************
# Copyright (c) 2024 Contributors to the Eclipse Foundation
# Copyright (c) 2026 Contributors to the Eclipse Foundation
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not replace copyright year in existing files. The year shall represent file creation (or last full rewrite)

Comment thread docs/conf.py Outdated


def setup(app):
app.add_css_file("css/score.css", priority=600)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introducing a new style file means we need someone to maintain it, as new docs-as-code versions can easily be incompatible. score repo is notoriously unmaintained.

@antonkri antonkri force-pushed the ankr_improve_onboarding_doc branch 8 times, most recently from 2438e90 to 6e8863b Compare May 21, 2026 16:54
@antonkri antonkri changed the title WIP: improve onboarding documentation Improve onboarding documentation May 24, 2026
@antonkri antonkri force-pushed the ankr_improve_onboarding_doc branch from 6e8863b to d1837e4 Compare May 24, 2026 08:53
@antonkri antonkri force-pushed the ankr_improve_onboarding_doc branch from d1837e4 to 6035679 Compare May 25, 2026 09:40
Copy link
Copy Markdown
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments resolved

@antonkri antonkri dismissed anmittag’s stale review May 26, 2026 08:02

Due to unavailibility

@antonkri antonkri merged commit a2a757a into main May 26, 2026
8 checks passed
@antonkri antonkri deleted the ankr_improve_onboarding_doc branch May 26, 2026 08:07
@github-project-automation github-project-automation Bot moved this from Backlog to Done in S-CORE Roadmap May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

9 participants