Wrong target name for AutoSD in score_starter and wrong label in menu#235
Wrong target name for AutoSD in score_starter and wrong label in menu#235dirkmacke wants to merge 2 commits into
Conversation
dirkmacke
requested review from
AlexanderLanin,
FScholPer,
MaximilianSoerenPollak,
PiotrKorkus,
antonkri,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
|
The created documentation from the pull request is available at: docu-html |
PiotrKorkus
left a comment
PiotrKorkus
left a comment
There was a problem hiding this comment.
hi @dirkmacke,
https://github.com/eclipse-score/reference_integration/actions/runs/26222544509/workflow?pr=235
Current workflow for autosd tests the image with qemu. Shall we include docker build/test as well to make sure ./score_starter will work correctly?
| - [QNX](./images/qnx_x86_64//README.md) | ||
| - [Red Hat AutoSD](./images/autosd_x86_64/build/README.md) | ||
| - [Red Hat AutoSD](./images/autosd/) |
There was a problem hiding this comment.
sections says there should be README reference, could you add it?
There was a problem hiding this comment.
I am new to this, but the QEMU build seems not to be included - that's what I tried to build, but it failed. The existing target - //images/autosd does build a container. Renaming of //image/.. fixed the build issue, but I thought the menu in score_startershould correctly mention, that a container is being build.
So the docker build is actually what's there, QEMU seems to be missing (unless the container actually runs QEMU inside... didn't go that deep, TBH, trying to learn the ropes). As for our purposes, the container is actually very convenient, so it should stay.
The README.md reference is the line I changed, so that it correctly refers to ./images/autosd instead of .../autosd_x86_64/....
2 participants
'score_starter' refers to
//images/autosd_x86_x64, but the target is actually calledautosd.The menu in
score_starterwrongly states QEMU when actually a docker container is built.