Repository navigation
Fix public api visiblity for datarouter targets - #439
Merged
Merged
Conversation
rmaddikery
requested a deployment
to
workflow-approval
November 19, 2026 12:33 — with
GitHub Actions
Waiting
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
rmaddikery
requested a deployment
to
workflow-approval
November 19, 2026 12:37 — with
GitHub Actions
Waiting
rmaddikery
force-pushed
the
rama_datarouterconf_public_api
branch
from
November 19, 2026 12:46
ede8931 to
f5ba5da
Compare
Contributor
|
Documentation preview for this pull request is available at: |
rmaddikery
requested a deployment
to
workflow-approval
November 19, 2026 14:00 — with
GitHub Actions
Waiting
rmaddikery
requested a deployment
to
workflow-approval
November 19, 2026 14:15 — with
GitHub Actions
Waiting
rmaddikery
force-pushed
the
rama_datarouterconf_public_api
branch
from
November 20, 2026 07:52
23af0a8 to
9eb030d
Compare
rmaddikery
marked this pull request as ready for review
November 20, 2026 07:54
rmaddikery
requested review from
4og,
antonkri and
hoppe-and-dreams
as code owners
November 20, 2026 07:54
Contributor
There was a problem hiding this comment.
This file has no file ending. Is it supposed to be header?
| kSharedMemoryFileHandle = 1, | ||
| }; | ||
|
|
||
| struct SocketMessangerHeader // __attribute__((packed)) // TODO: deal with packed |
Contributor
There was a problem hiding this comment.
What is meant here by "dealt with it"? Do we have a ticket for this TODO?
Contributor
Author
There was a problem hiding this comment.
this was a legacy take over. I added a comment instead.
rmaddikery
force-pushed
the
rama_datarouterconf_public_api
branch
from
November 20, 2026 10:08
9eb030d to
40d9519
Compare
rmaddikery
requested a deployment
to
workflow-approval
November 20, 2026 10:08 — with
GitHub Actions
Waiting
- Both targets only carry constants (command and return codes, socket and client names) that form the contract between datarouter and the clients configuring it.
- External datarouter clients use UnixDomainSockAddr, SendSocketMessage and RecvSocketMessage to talk to the datarouter socket, which is most of the public surface of this target.
- Remove the entries instead of leaving lists that suggest access which is not granted.
Include <string> and define the constants inline. This makes the header self-contained and avoids per-translation-unit copies.
- The target is the client API for triggering DLT file transfers.
Use "Datarouter Configurator Client" as the IPC diagram node label.
Introduce data_router_cfg as the canonical target. Preserve the libdrconfighdrs label with an alias and retain the short include path until external consumers migrate.
- Switch the in-repo dependencies from the libdrconfighdrs alias to data_router_cfg and include the header via its repo-root-relative path, so only external consumers still rely on the transitional alias and includes.
Remove the visibility label for a package that does not exist in this repository. Consumers depend on dlt_filetransfer_trigger_lib and do not use these message headers directly.
- Add a datarouter-private target and header for the unix domain declarations that are not part of the client API. - Migrate the client, the server and their tests to it. The header still forwards to unix_domain_common.h, so no declaration moves yet.
- Move internals to unix_domain_internal.h. The public header keeps UnixDomainSockAddr, SendSocketMessage and RecvSocketMessage, so existing external consumers need no change.
- avoid leaking transitive deps for public targets
- The target is private and has no dependents, and nothing includes the extension-less StructDataSource header that it exports. - Drop the target from the datarouter dependency report scope as well.
- The header is sent as raw bytes, and packing it would change the wire format.
- Fix deprecation warning comment for legacy label
rmaddikery
force-pushed
the
rama_datarouterconf_public_api
branch
from
November 20, 2026 10:09
40d9519 to
e8759d0
Compare
hoppe-and-dreams
approved these changes
Nov 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #