Skip to content

Add generic content to inspections - #432

Merged
rmaddikery merged 1 commit into
mainfrom
aschemmel-tech-formalize-inspections
Nov 19, 2026
Merged

rmaddikery merged 1 commit into
mainfrom
aschemmel-tech-formalize-inspections

Conversation

@aschemmel-tech

Copy link
Copy Markdown
Contributor

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.8.2) and connecting to it...
INFO: Invocation ID: 045fa6ca-0c3f-41a4-bf72-3256da51e1b7
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.2.17, but got rules_cc@0.2.25 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: /home/runner/.bazel/external/score_baselibs+/score/json/BUILD:25:12: target '@@score_baselibs+//score/json:base_library' is deprecated: base_library no longer has any effect, vaJson is the only parser backend. Remove this flag from your build configuration; it will be deleted in a future release.
Loading: 
Loading: 4 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 15.526s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@aschemmel-tech
aschemmel-tech force-pushed the aschemmel-tech-formalize-inspections branch from 2808419 to b71777e Compare November 18, 2026 15:13
@aschemmel-tech
aschemmel-tech deployed to workflow-approval November 18, 2026 15:13 — with GitHub Actions Active
@aschemmel-tech
aschemmel-tech marked this pull request as ready for review November 18, 2026 15:13

@MaciejKaszynski MaciejKaszynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add the reasons why in a subsequent pr. So this can be merged as is.

@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-432: https://eclipse-score.github.io/logging/pr-432/

@github-project-automation github-project-automation Bot moved this from Backlog to On Hold in LOG - Logging FT Nov 19, 2026
@rmaddikery
rmaddikery enabled auto-merge November 19, 2026 14:50
@rmaddikery
rmaddikery added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 543a588 Nov 19, 2026
23 of 24 checks passed
@rmaddikery
rmaddikery deleted the aschemmel-tech-formalize-inspections branch November 19, 2026 15:55
@github-project-automation github-project-automation Bot moved this from On Hold to Done in LOG - Logging FT Nov 19, 2026

This branch was successfully deployed

1 active deployment
workflow-approval — b71777e6 Deployed Nov 18, 2026 by aschemmel-tech via run-tests / coverage approval gate #1809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants