chore: adopt cicd-workflows for pre-commit and lint CI#72
Conversation
|
Hi @alexmohr, Thanks for your first pull request! Before we can accept your contribution, please ensure you have:
We appreciate your contribution and will review it as soon as possible. |
| # SPDX-FileCopyrightText: Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # SPDX-FileCopyrightText: 2025 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS) |
There was a problem hiding this comment.
todo: must be fixed later, that the year changed.
|
@lh-sag This would align the ci settings with the cicd shared ones.
The I want to discuss details in the next architecture round: See |
|
Changes from #71 are adopted in cicd already :) |
|
@alexmohr I am fine with aligning but that should not stop from addressing the issues we have right now. I would like to address the concerns I and other have and once settled we can move on unifying. Otherwise we end up in a very unstable CI/CD/ |
e2ef96c to
fdd777f
Compare
Sure I'm on the same page with you here. I'm mainly trying out what works and what doesn't once I have something should work for everyone I will bring this up again. The PRs are still draft for a reason. We can discuss details on the opensovd or s-core workshop. |
fdd777f to
c72a38e
Compare
898677e to
fe8caed
Compare
fe8caed to
f7364a6
Compare
Summary
eclipse-opensovd/cicd-workflowshooks (reuse-annotate, no-unicode-check, no-banner-comment-check, validate-cargo-lints, cargo-fmt, clippy, check-hooks).yamlfmt,.markdownlint.yaml,.rustfmt.tomlto match canonical configs from cicd-workflowsrustfmt.toml(.rustfmt.tomlis the canonical location)eclipse-opensovd/cicd-workflows/pre-commit-actioncomposite actiongit-lintjobKnown Items
validate-cargo-lintsmay flagpedantic(deny vs shared warn) andclone_on_ref_ptr(deny vs shared warn) as mismatches — opensovd-core is stricter than the shared baseline. Options: relax to match shared-lints.toml, or updatecheck_cargo_lints.pyto accept stricter levels.cicd-workflows@feat/pre-commit-hook-args-configbranch (PR chore(deps): Bump requests from 2.32.5 to 2.33.0 #39) — update rev to a release SHA once merged.Depends On