Skip to content

chore: adopt cicd-workflows for pre-commit and lint CI#72

Draft
alexmohr wants to merge 1 commit into
mainfrom
chore/adopt-cicd-workflows
Draft

chore: adopt cicd-workflows for pre-commit and lint CI#72
alexmohr wants to merge 1 commit into
mainfrom
chore/adopt-cicd-workflows

Conversation

@alexmohr
Copy link
Copy Markdown

@alexmohr alexmohr commented May 8, 2026

Summary

  • Replaces standalone pre-commit hooks with eclipse-opensovd/cicd-workflows hooks (reuse-annotate, no-unicode-check, no-banner-comment-check, validate-cargo-lints, cargo-fmt, clippy, check-hooks)
  • Updates .yamlfmt, .markdownlint.yaml, .rustfmt.toml to match canonical configs from cicd-workflows
  • Removes redundant rustfmt.toml (.rustfmt.toml is the canonical location)
  • Replaces manual lint CI setup with eclipse-opensovd/cicd-workflows/pre-commit-action composite action
  • Moves conventional commit validation to the git-lint job

Known Items

  • validate-cargo-lints may flag pedantic (deny vs shared warn) and clone_on_ref_ptr (deny vs shared warn) as mismatches — opensovd-core is stricter than the shared baseline. Options: relax to match shared-lints.toml, or update check_cargo_lints.py to accept stricter levels.
  • References cicd-workflows@feat/pre-commit-hook-args-config branch (PR chore(deps): Bump requests from 2.32.5 to 2.33.0 #39) — update rev to a release SHA once merged.

Depends On

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Hi @alexmohr,

Thanks for your first pull request!

Before we can accept your contribution, please ensure you have:

  1. Signed the Eclipse Contributor Agreement (ECA)
  2. Run the prek hooks as documented in CONTRIBUTING.md

We appreciate your contribution and will review it as soon as possible.

@github-actions github-actions Bot added the ci label May 8, 2026
Comment thread .markdownlint.yaml Outdated
# SPDX-FileCopyrightText: Copyright (c) 2026 Contributors to the Eclipse Foundation
# SPDX-License-Identifier: Apache-2.0

# SPDX-FileCopyrightText: 2025 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: must be fixed later, that the year changed.

@alexmohr
Copy link
Copy Markdown
Author

alexmohr commented May 8, 2026

@lh-sag This would align the ci settings with the cicd shared ones.
For most things I used this repo as reference as it had the most strict rules.

  1. It would be great if we could agree on the rust formatting style.
    In CDA we use imports_granularity = "Crate" in rustfmt which groups imports. It would be cool if we accept this as common base.

  2. We should agree on a copyright header, obviously I prefer the one from the CDA, iirc there was some legal reasons we opted for the verbose one. @floroks might remember. Speaking of copyright headers, some files are missing the headers, so we would definitely profit from adopting a shared pre commit config.

The no-unicode and no-banner-comment check are optional and we could remove them from here.
I will open similar PRs in the remaining repos.

I want to discuss details in the next architecture round: See
Will be part of the next architecture agenda eclipse-opensovd/opensovd#8 (comment)

@alexmohr
Copy link
Copy Markdown
Author

alexmohr commented May 8, 2026

Changes from #71 are adopted in cicd already :)

@lh-sag
Copy link
Copy Markdown
Contributor

lh-sag commented May 8, 2026

@alexmohr I am fine with aligning but that should not stop from addressing the issues we have right now.

I would like to address the concerns I and other have and once settled we can move on unifying. Otherwise we end up in a very unstable CI/CD/

@alexmohr alexmohr force-pushed the chore/adopt-cicd-workflows branch from e2ef96c to fdd777f Compare May 15, 2026 11:52
@alexmohr
Copy link
Copy Markdown
Author

@alexmohr I am fine with aligning but that should not stop from addressing the issues we have right now.

I would like to address the concerns I and other have and once settled we can move on unifying. Otherwise we end up in a very unstable CI/CD/

Sure I'm on the same page with you here. I'm mainly trying out what works and what doesn't once I have something should work for everyone I will bring this up again. The PRs are still draft for a reason. We can discuss details on the opensovd or s-core workshop.

@alexmohr alexmohr force-pushed the chore/adopt-cicd-workflows branch from fe8caed to f7364a6 Compare May 18, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants