Skip to content

[RelEng] Remove explicit versions from p2-repository#365

Open
HannesWell wants to merge 1 commit intoeclipse-mwe:masterfrom
HannesWell:remove-versions-from-categories
Open

[RelEng] Remove explicit versions from p2-repository#365
HannesWell wants to merge 1 commit intoeclipse-mwe:masterfrom
HannesWell:remove-versions-from-categories

Conversation

@HannesWell
Copy link
Copy Markdown
Contributor

Instead include the latest version of mentioned dependencies.

No version and 0.0.0 are equivalent.

Instead include the latest version of mentioned dependencies.
<feature id="org.eclipse.emf.mwe.sdk" version="0.0.0">
<category name="mwe2lang"/>
</feature>
<bundle id="com.google.guava" version="33.5.0.qualifier"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am not sure if we will end up with multiple versions again

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be only the latest version, like with 0.0.0.
Of course if mwe references an earlier version of Guava that one is missing. But as far as I know MWE doesn't have special restrictions on Guava?

Of course if MWE would be migrated off Guava, that wouldn't be necessary at all (only as transitive dependency for Xtext maybe):

But that's another topic.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we try to use consisten versions in the xtext / mwe / xpect ecosystem and had problems in the past. this is why we initially bundle consistent versions over the place.
so i dont know if we will get in a state again where there is more than one version availble
(might be worse with cli as that one might also be used by other places in simrel)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and ofc migrate off wont work as we inherit it from xtext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants