Fixes Duplicate Key Binding Triggers on WebKit#97
Draft
N1k145 wants to merge 1 commit intoeclipse-glsp:masterfrom
Draft
Fixes Duplicate Key Binding Triggers on WebKit#97N1k145 wants to merge 1 commit intoeclipse-glsp:masterfrom
N1k145 wants to merge 1 commit intoeclipse-glsp:masterfrom
Conversation
Without this fix there are duplicated Key Binding Triggers on WebKit as the fix provided by BrowserKeyBindingForwarderInstaller is only an Issue on Chrome and Edge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-glsp/glsp#874
Without this fix there are duplicated Key Binding Triggers on WebKit as the fix provided by BrowserKeyBindingForwarderInstaller is only an Issue on Chrome and Edge
What it does
Fixes Duplicate Key Binding Triggers on WebKit
How to test
Start the example on Windows and Linux,
Set the Focus in the Web browser View
Make sure that in both cases, Ctrl+H opens the Eclipse Search once.
Changelog