CI: restore default workflow triggers and fix windows reusable-summary reference#2632
Open
YannikSpaeth wants to merge 24 commits into
Open
CI: restore default workflow triggers and fix windows reusable-summary reference#2632YannikSpaeth wants to merge 24 commits into
YannikSpaeth wants to merge 24 commits into
Conversation
…pdate PR number handling
Test reusable CI failure summary workflow integration
Extract CI failure summary into reusable workflow
Removed intentional failure tests for summary validation.
FlorianReimold
requested changes
May 28, 2026
FlorianReimold
left a comment
FlorianReimold
left a comment
Member
There was a problem hiding this comment.
Currently I see 2 remaining issues with this PR:
-
The action fails for PRs that come from forks. This PR is a good example by itself for that. The reduces permissions of the github token for fork PRs are by design and should not be changed. However, the action should also not go to a failed state for every fork PR. An acceptable solution would be to simply skip the action, as it cannot post comments anyways.
-
The action is triggered by pushes (i.e. triggers that are non-PR related), but don’t react on that. It always tries to obtain the PR number and operate with it. I am not sure what happens in that case (fail / PR number 0 / maybe it is handles somewhere else?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts temporary CI trigger restrictions and fixes the Windows reusable summary workflow reference.