Added php 7.4#252
Added php 7.4#252BhawaniSingh wants to merge 1 commit intoeclipse-che:masterfrom BhawaniSingh:master
Conversation
JPinkney
left a comment
There was a problem hiding this comment.
@BhawaniSingh You'll need to sign the eclipse contributor agreement and sign your commit and then I can merge this PR and fix the sample!
|
I tried to sign the ECA, but I'm facing issue,
It was because my email set to private in github, even though I changed my mail to public, I'm still seeing this issue. |
|
@BhawaniSingh I think you have to sign the commit. You must have git config https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Signing_off_on_a_commit |
What does this PR do?
Added php 7.4
What issues does this PR fix or reference?
Symphony demo doesn't work with php 7.1
Previous behavior
(Remove this section if not relevant)
New behavior
(Explain the PR as it should appear in the release notes)
Please review Che's Contributing Guide for best practices.
Tests written?
No
Docs updated?
Please add a matching PR to the docs repo and link that PR to this issue. Both will be merged at the same time.