server: Discovery PostAllAssetLinksById does not replace links #669

Activity

1. zrgt commented on Oct 22, 2026

   

   zrgt

   on Oct 22, 2026

   ContributorAuthor

   More actions

   While fixing this: the reverse index (asset_id_to_aas_ids) is
   maintained in the handlers, not in DiscoveryStore.
   post_all_asset_links_by_id calls the private
   _add_aas_id_to_specific_asset_id(), and
   delete_all_asset_links_by_id loops over the store's dict and
   leaves empty sets behind:

   basyx-python-sdk/server/app/interfaces/discovery.py

   Lines 222 to 240 in 2773ac0

   	def post_all_asset_links_by_id(
   	self, request: Request, url_args: dict, response_t: Type[APIResponse], **_kwargs
   	) -> Response:
   	aas_identifier = str(url_args["aas_id"])
   	specific_asset_ids = HTTPApiDecoder.request_body_list(request, model.SpecificAssetId, False)
   	self.persistent_store.add_specific_asset_ids_to_aas(aas_identifier, specific_asset_ids)
   	for asset_id in specific_asset_ids:
   	self.persistent_store._add_aas_id_to_specific_asset_id(asset_id, aas_identifier)
   	updated = {aas_identifier: self.persistent_store.get_all_specific_asset_ids_by_aas_id(aas_identifier)}
   	return response_t(updated)
   	def delete_all_asset_links_by_id(
   	self, request: Request, url_args: dict, response_t: Type[APIResponse], **_kwargs
   	) -> Response:
   	aas_identifier = str(url_args["aas_id"])
   	self.persistent_store.delete_specific_asset_ids_by_aas_id(aas_identifier)
   	for key in list(self.persistent_store.asset_id_to_aas_ids.keys()):
   	self.persistent_store.asset_id_to_aas_ids[key].discard(aas_identifier)
   	return response_t()

   Moving both updates into add_specific_asset_ids_to_aas() and
   delete_specific_asset_ids_by_aas_id() keeps the two maps in sync in
   one place, which is also where #663 would persist the store.
2. zrgt commented on Oct 22, 2026

   

   zrgt

   on Oct 22, 2026

   ContributorAuthor

   More actions

   Small addition: search_aas_ids_by_asset_link() scans the whole
   reverse index on every lookup, because it is keyed by
   SpecificAssetId (which also compares externalSubjectId and
   semantic ids) while a lookup only has name and value:

   basyx-python-sdk/server/app/interfaces/discovery.py

   Lines 59 to 64 in 2773ac0

   	def search_aas_ids_by_asset_link(self, asset_link: server_model.AssetLink) -> List[model.Identifier]:
   	result = []
   	for asset_key, aas_ids in self.asset_id_to_aas_ids.items():
   	if asset_key.name == asset_link.name and asset_key.value == asset_link.value:
   	result.extend(list(aas_ids))
   	return result

   If the index moves into DiscoveryStore anyway, keying it by
   (name, value) makes the lookup a dict access.
3. zrgt

   added

   bugSomething isn't workingSomething isn't working

   serverSomething to do with the `server` packageSomething to do with the `server` package

   on Oct 22, 2026