🐛 Fix exercise intensity dropdown selection state#59
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where selecting light or hard exercise intensity in the dropdown would revert to the initial value. The fix introduces deterministic state synchronization logic and explicit event forwarding to ensure user selections are preserved while still supporting late initial value updates for untouched fields.
Changes:
- Replaced fragile
on:changeevent handling with a deterministicsyncIntensityStateutility function that tracks dirty state and previous initial values - Added explicit event forwarding (
input,change,blur,focus) in theInput.sveltewrapper component - Added focused unit tests validating intensity state synchronization behavior across key scenarios
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sleep-ui/tests/unit/intensity.spec.ts | New test suite covering intensity state sync logic including dirty state tracking and late initial value updates |
| sleep-ui/src/lib/utils/intensity.ts | New utility module providing deterministic intensity state synchronization logic |
| sleep-ui/src/lib/components/SleepForm.svelte | Replaced reactive statement with syncIntensityState call and removed wrapper-level on:change handler |
| sleep-ui/src/lib/components/Input.svelte | Added event dispatcher and explicit event forwarding for safer parent event handling |
| docs/coding-agent/plans/completed/exercise-intensity-dropdown-investigation-plan.md | Archived investigation plan documenting the bug analysis and fix approach |
| docs/coding-agent/lessons.md | Added two new lessons learned about research task approval and test layer selection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Validation
Notes