♻️ Align sleep edit dark mode visuals and unify create/edit shell#57
Merged
♻️ Align sleep edit dark mode visuals and unify create/edit shell#57
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR unifies the “New sleep entry” and “Edit sleep entry” route chrome into a shared presentational shell that uses the app’s semantic theme tokens (improving dark-mode parity), and updates agent-process documentation around validation/evidence.
Changes:
- Added
SleepEntryShelland migrated sleep create/edit routes to use it (including semanticbtn-dangerstyling for delete). - Added troubleshooting guidance for persistent-terminal cwd drift and strengthened UI/E2E evidence checklist documentation.
- Added/updated plan + lessons documentation to reflect the execution/review process.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sleep-ui/src/routes/sleep/new/+page.svelte | Switches create page wrapper to shared SleepEntryShell. |
| sleep-ui/src/routes/sleep/[id]/edit/+page.svelte | Switches edit page wrapper to shared SleepEntryShell and uses btn-danger for delete. |
| sleep-ui/src/lib/components/SleepEntryShell.svelte | New shared wrapper component for create/edit header + card chrome. |
| docs/coding-agent/troubleshooting/persistent-terminal-cwd.md | New troubleshooting note for persistent terminal cwd mismatches. |
| docs/coding-agent/troubleshooting/index.md | Adds index entry for the new troubleshooting doc. |
| docs/coding-agent/references/ui-e2e.md | Adds an artifact presence check to the UI/E2E evidence checklist. |
| docs/coding-agent/plans/completed/sleep-edit-theme-shell-unification-plan.md | Adds completed plan document for this work. |
| docs/coding-agent/lessons.md | Adds lessons capturing reviewer-evidence and cwd validation deviations. |
Comments suppressed due to low confidence (2)
docs/coding-agent/plans/completed/sleep-edit-theme-shell-unification-plan.md:3
- This completed plan uses
- status: done, but other plans underdocs/coding-agent/plans/completed/usestatus: completed(anddocs/coding-agent/lessons.mdalso references updating plans tostatus: completed). Align this plan’s status value to the repo’s dominant convention to avoid confusion and keep any tooling/queries consistent.
- status: done
docs/coding-agent/lessons.md:120
- This lesson references the plan path under
plans/active/, but the plan appears to be indocs/coding-agent/plans/completed/(and there is no corresponding file inplans/active/). Update the reference so it points to the current location to avoid broken links.
Context:
- Plan: docs/coding-agent/plans/active/sleep-edit-theme-shell-unification-plan.md
- Task/Wave: Task_2 / Wave 2
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SleepEntryShellas a presentational shared shell for create/edit routesWhat changed
sleep-ui/src/lib/components/SleepEntryShell.svelte(new)sleep-ui/src/routes/sleep/new/+page.sveltenow uses shared shellsleep-ui/src/routes/sleep/[id]/edit/+page.sveltenow uses shared shell + semantic danger button classValidation
cd sleep-ui && npm run checkcd sleep-ui && npm run test:unitcd sleep-ui && npm run build