Skip to content

♻️ Align sleep edit dark mode visuals and unify create/edit shell#57

Merged
ebigunso merged 1 commit intomainfrom
feat/sleep-edit-darkmode-dry-shell
Feb 21, 2026
Merged

♻️ Align sleep edit dark mode visuals and unify create/edit shell#57
ebigunso merged 1 commit intomainfrom
feat/sleep-edit-darkmode-dry-shell

Conversation

@ebigunso
Copy link
Owner

@ebigunso ebigunso commented Feb 21, 2026

Summary

  • apply dark-mode-ready semantic UI tokens to the sleep edit wrapper chrome
  • keep create/edit behavior unchanged while unifying shared wrapper UI
  • introduce SleepEntryShell as a presentational shared shell for create/edit routes

What changed

  • sleep-ui/src/lib/components/SleepEntryShell.svelte (new)
  • sleep-ui/src/routes/sleep/new/+page.svelte now uses shared shell
  • sleep-ui/src/routes/sleep/[id]/edit/+page.svelte now uses shared shell + semantic danger button class
  • docs updates from execution/review process logs

Validation

  • cd sleep-ui && npm run check
  • cd sleep-ui && npm run test:unit
  • cd sleep-ui && npm run build
  • reviewer UI evidence screenshots for create/edit dark mode

Copilot AI review requested due to automatic review settings February 21, 2026 23:42
@ebigunso ebigunso self-assigned this Feb 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unifies the “New sleep entry” and “Edit sleep entry” route chrome into a shared presentational shell that uses the app’s semantic theme tokens (improving dark-mode parity), and updates agent-process documentation around validation/evidence.

Changes:

  • Added SleepEntryShell and migrated sleep create/edit routes to use it (including semantic btn-danger styling for delete).
  • Added troubleshooting guidance for persistent-terminal cwd drift and strengthened UI/E2E evidence checklist documentation.
  • Added/updated plan + lessons documentation to reflect the execution/review process.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sleep-ui/src/routes/sleep/new/+page.svelte Switches create page wrapper to shared SleepEntryShell.
sleep-ui/src/routes/sleep/[id]/edit/+page.svelte Switches edit page wrapper to shared SleepEntryShell and uses btn-danger for delete.
sleep-ui/src/lib/components/SleepEntryShell.svelte New shared wrapper component for create/edit header + card chrome.
docs/coding-agent/troubleshooting/persistent-terminal-cwd.md New troubleshooting note for persistent terminal cwd mismatches.
docs/coding-agent/troubleshooting/index.md Adds index entry for the new troubleshooting doc.
docs/coding-agent/references/ui-e2e.md Adds an artifact presence check to the UI/E2E evidence checklist.
docs/coding-agent/plans/completed/sleep-edit-theme-shell-unification-plan.md Adds completed plan document for this work.
docs/coding-agent/lessons.md Adds lessons capturing reviewer-evidence and cwd validation deviations.
Comments suppressed due to low confidence (2)

docs/coding-agent/plans/completed/sleep-edit-theme-shell-unification-plan.md:3

  • This completed plan uses - status: done, but other plans under docs/coding-agent/plans/completed/ use status: completed (and docs/coding-agent/lessons.md also references updating plans to status: completed). Align this plan’s status value to the repo’s dominant convention to avoid confusion and keep any tooling/queries consistent.
- status: done

docs/coding-agent/lessons.md:120

  • This lesson references the plan path under plans/active/, but the plan appears to be in docs/coding-agent/plans/completed/ (and there is no corresponding file in plans/active/). Update the reference so it points to the current location to avoid broken links.
Context:
- Plan: docs/coding-agent/plans/active/sleep-edit-theme-shell-unification-plan.md
- Task/Wave: Task_2 / Wave 2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ebigunso ebigunso changed the title Align sleep edit dark mode visuals and unify create/edit shell ♻️ Align sleep edit dark mode visuals and unify create/edit shell Feb 21, 2026
@ebigunso ebigunso merged commit 37bd834 into main Feb 21, 2026
6 checks passed
@ebigunso ebigunso deleted the feat/sleep-edit-darkmode-dry-shell branch February 21, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants