Don't install test.framework package
#5070
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
install-test
branch
from
0762228 to
d0943f2
Compare
boegel
changed the title
test.framework package
This results in a top-level Python package called "test". As this isn't namespaced to easybuild it can cause issues with other Python packages and shouldn't be installed.
When we no longer install the test package AND want to run outside the source tree (to test the installed easybuild package) we need to retrieve the test package first.
We need to use `$PYTHONPATH` instead of `topdir` to include the framework package in the GC3Pie test. When testing copies of framework files we need to handle the case where some might not be available and try hard to find the source dir.
Flamefire
force-pushed
the
install-test
branch
from
d0943f2 to
fd77d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in a top-level Python package called "test". As this isn't namespaced to easybuild it can cause issues with other Python packages and shouldn't be installed.
Additionally IMO it isn't useful to install the tests in the first place.