Skip to content

feat(settings): change card detail control in CheckpointSettings + webview default (B3a v2-9, epic #1375) - #52

Open
easonLiangWorldedtech wants to merge 1 commit into
feat/fws-v2-8b-editsearch-wiringfrom
feat/fws-v2-9-settings-ui
Open

easonLiangWorldedtech wants to merge 1 commit into
feat/fws-v2-8b-editsearch-wiringfrom
feat/fws-v2-9-settings-ui

Conversation

@easonLiangWorldedtech

Copy link
Copy Markdown
Owner

What this PR does

Settings/UI tail of the B3a change-card feature (epic Zoo-Code-Org#1375), stacked on #51 (v2-8b):

  • CheckpointSettings: new "Change card detail" control (summary / full) bound to local cachedState and saved through the updateSettings payload (changeCardDetail), per the SettingsView cache pattern.
  • SettingsView: wiring for the new control; changeCardDetail added to the settings cache.
  • ExtensionState: changeCardDetail defaults to "summary" in createInitialExtensionState; mergeExtensionState preserves the stored value when the incoming state omits the key.
  • i18n: settings:checkpoints.changeCardDetail.{label,description} in all 18 locales (nested under checkpoints, sibling of perWrite).
  • Specs: B3a-parity CheckpointSettings / SettingsView specs + ExtensionStateContext spec (pre-hydration defaults, merge retention with non-default fixtures).

Line count / split rationale

355 changed lines (337+/18-) across 24 files — below the 400 soft design target. The file count is inflated by the 18 locale JSONs (each +4 lines for the two new keys); the actual logic change is the settings control wiring plus the context default/merge handling.

Not included here (later v2 PRs)

  • Rollback core + service — v2-10 / v2-11.
  • Rollback UI + remaining epic work — v2-12..v2-15.

Local gates

  • Vitest (3 touched suites): 57 passed (including 2 new CheckpointSettings assertions pinning the searchable label and the rendered description).
  • ESLint --prune-suppressions --max-warnings=0 on the 6 TS/TSX files: clean.
  • Prettier: all 24 files content-clean under the repo prettier config (LF-normalized API audit).
  • Stryker diff gate: 14 mutants — 14 Killed, 0 Survived, 0 NoCoverage (run against pre-rebase base e6133ebed; diff content unchanged by the rebase onto 49452076d).

@github-actions

github-actions Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Review status

Thanks for contributing. This comment tracks the review sequence and the next action.

Current step: Required CI passed. Waiting for automated review of the latest commit.

If automated review does not start, a maintainer must restart it.

Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.

@easonLiangWorldedtech
easonLiangWorldedtech force-pushed the feat/fws-v2-8b-editsearch-wiring branch from 4945207 to 63d9b09 Compare September 6, 2026 02:30
@github-actions github-actions Bot added coderabbit-review-active Required CI passed; CodeRabbit review is active and removed coderabbit-review-active Required CI passed; CodeRabbit review is active labels Sep 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-coderabbit Waiting for CodeRabbit to approve the latest commit coderabbit-review-active Required CI passed; CodeRabbit review is active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants