-
Notifications
You must be signed in to change notification settings - Fork 8
[#24061] Updated read_next_command() for the new FastDDS-Spy filter
#148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 60.43% 60.21% -0.22%
==========================================
Files 65 65
Lines 1921 1933 +12
Branches 543 552 +9
==========================================
+ Hits 1161 1164 +3
- Misses 440 447 +7
- Partials 320 322 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
cbccb71 to
15a18b3
Compare
Signed-off-by: danipiza <[email protected]>
rsanchez15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review the case when the command does not have closing "
cpp_utils/include/cpp_utils/user_interface/impl/CommandReader.ipp
Outdated
Show resolved
Hide resolved
Signed-off-by: danipiza <[email protected]>
cpp_utils/include/cpp_utils/user_interface/impl/CommandReader.ipp
Outdated
Show resolved
Hide resolved
Signed-off-by: danipiza <[email protected]>
rsanchez15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added new function:
This function is used in
read_next_command(Command<CommandEnum>& command)to join quotes in a single argument. Used in FastDDS-Spy filter by topic (Content Filtered Topic)read_next_command()it is only used in FastDDS-Spy.https://github.com/search?q=org%3AeProsima%20read_next_command(&type=code
Example