Skip to content

Conversation

@Danipiza
Copy link
Contributor

@Danipiza Danipiza commented Jan 16, 2026

Added new function:

std::vector<std::string> join_quoted_strings(
        const std::vector<std::string>& input);

This function is used in read_next_command(Command<CommandEnum>& command) to join quotes in a single argument. Used in FastDDS-Spy filter by topic (Content Filtered Topic)

read_next_command() it is only used in FastDDS-Spy.
https://github.com/search?q=org%3AeProsima%20read_next_command(&type=code

Example

// command = filter set topic HelloWorldTopic "index > 10" 

Before: ["filter", "set", "topic", "HelloWorldTopic", "\"index", ">", "10\"" ] // Size: 7
After:  ["filter", "set", "topic", "HelloWorldTopic", "index > 10" ] // Size: 5

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.21%. Comparing base (306edca) to head (4c87039).

Files with missing lines Patch % Lines
...de/cpp_utils/user_interface/impl/CommandReader.ipp 30.76% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   60.43%   60.21%   -0.22%     
==========================================
  Files          65       65              
  Lines        1921     1933      +12     
  Branches      543      552       +9     
==========================================
+ Hits         1161     1164       +3     
- Misses        440      447       +7     
- Partials      320      322       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the case when the command does not have closing "

Copy link
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danipiza Danipiza merged commit 8a826bb into main Feb 2, 2026
15 checks passed
@Danipiza Danipiza deleted the feature/new-filter branch February 2, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants