Skip to content

[24046] Update security tests to use governance-based encryption configuration#6277

Open
emiliocuestaf wants to merge 20 commits intomasterfrom
bugfix/security-tests
Open

[24046] Update security tests to use governance-based encryption configuration#6277
emiliocuestaf wants to merge 20 commits intomasterfrom
bugfix/security-tests

Conversation

@emiliocuestaf
Copy link
Copy Markdown
Contributor

@emiliocuestaf emiliocuestaf commented Jan 26, 2026

Description

The properties rtps.participant.rtps_protection_kind, rtps.endpoint.submessage_protection_kind, and rtps.endpoint.payload_protection_kind are not parsed in the Fast-DDS source code. These properties are set in multiple blackbox security tests, but they have no effect on the actual encryption behavior.

The only valid way to configure RTPS/endpoint protection kinds is through the governance file with the Access Control plugin enabled.

The properties rtps.participant.rtps_protection_kind, rtps.endpoint.submessage_protection_kind, and rtps.endpoint.payload_protection_kind are not parsed in the Fast-DDS source code. These properties are set in multiple blackbox security tests, but they have no effect on the actual encryption behavior.

The only valid way to configure RTPS/endpoint protection kinds is through the governance file with the Access Control plugin enabled.

This PR includes the following features:

  • Modify the security Blackbox tests so that the protection kinds are correctly set and, hence, tested.
  • Add parameters to tests so that all combinations between {TRANSPORT, INTRAPROCESS, DATASHARING} and {BEST_EFFORT, RELIABLE} are evaluated along with every security combination
  • Fix BEST_EFFORT tests that were flaky
  • Fix performance tests, whose security set-up was also outdated
  • Test every security setting under larga data too.

@Mergifyio backport 3.5.x 3.4.x 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@emiliocuestaf emiliocuestaf added this to the v3.5.0 milestone Jan 26, 2026
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jan 26, 2026
@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima January 26, 2026 16:31
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 27, 2026

🧪 CI Insights

Here's what we observed from your CI run for efe835d.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, unittest-II), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, unittest-II), v143 Unknown 0 View View

@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima January 27, 2026 09:37
@rsanchez15 rsanchez15 modified the milestones: v3.5.0, v3.5.1 Feb 23, 2026
@emiliocuestaf emiliocuestaf modified the milestones: v3.5.1, v3.6.0 Mar 3, 2026
@zesk1999 zesk1999 self-requested a review March 20, 2026 10:23
zesk1999
zesk1999 previously approved these changes Mar 20, 2026
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
…on_kind

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf force-pushed the bugfix/security-tests branch from 517886f to bb6c126 Compare March 23, 2026 09:09
@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima March 23, 2026 09:10
@zesk1999 zesk1999 self-requested a review March 23, 2026 09:14
@MiguelCompany MiguelCompany modified the milestones: v3.6.0, v3.6.1 Mar 25, 2026
@MiguelCompany MiguelCompany modified the milestones: v3.6.1, v3.6.2 Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants