Skip to content

Conversation

@raulojeda22
Copy link

@raulojeda22 raulojeda22 commented Jan 20, 2026

Description

Fix compilation with GCC 15 by adding missing #include <cstdint> to SharedSecretHandle.h.
GCC 15 is stricter about implicit includes, and uint8_t requires an explicit #include <cstdint>. Without this include, compilation fails with errors like:

error: 'uint8_t' was not declared in this scope

Additionally, GCC 15 shows a false positive warning in sqlite3.c:

warning: ‘strlen’ reading 1 or more bytes from a region of size 0 [-Wstringop-overread]
35253 |   return 0x3fffffff & (int)strlen(z);

Which is fixed in this PR by changing the if statement to a ternary operator.

@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x

Fixes #6254

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@raulojeda22 raulojeda22 added this to the v3.5.0 milestone Jan 20, 2026
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add also CMake flags into this line to build Fast DDS with Security and Statistics features in the alternative build workflow

@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 20, 2026
@raulojeda22 raulojeda22 changed the title [24101] Include cstdint needed in GCC 15 [24101] Fix build in GCC 15 Jan 20, 2026
openssl

ENTRYPOINT ["/bin/bash", "-c", "cd && colcon build --event-handlers=console_direct+"]
ENTRYPOINT ["/bin/bash", "-c", "cd && colcon build --event-handlers=console_direct+ -DSECURITY=ON -DFASTDDS_STATISTICS=ON"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing --cmake-args before the new flags

#include <rtps/security/common/Handle.h>

#include <vector>
#include <cstdint>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this before the <vector> include to use alphabetical order

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2026

🧪 CI Insights

Here's what we observed from your CI run for 37e96d5.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Ubuntu CI ubuntu-ci / fastdds_docs_test (RelWithDebInfo) Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, blackbox), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, unittest-II), v142 Unknown 0 View View

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS Ubuntu CI ubuntu-ci / fastdds_build (RelWithDebInfo) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing cstdint include

3 participants