-
Notifications
You must be signed in to change notification settings - Fork 891
[24101] Fix build in GCC 15 #6263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Raül <[email protected]>
cferreiragonz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add also CMake flags into this line to build Fast DDS with Security and Statistics features in the alternative build workflow
Signed-off-by: Raül <[email protected]>
Signed-off-by: Raül <[email protected]>
| openssl | ||
|
|
||
| ENTRYPOINT ["/bin/bash", "-c", "cd && colcon build --event-handlers=console_direct+"] | ||
| ENTRYPOINT ["/bin/bash", "-c", "cd && colcon build --event-handlers=console_direct+ -DSECURITY=ON -DFASTDDS_STATISTICS=ON"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing --cmake-args before the new flags
| #include <rtps/security/common/Handle.h> | ||
|
|
||
| #include <vector> | ||
| #include <cstdint> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this before the <vector> include to use alphabetical order
Signed-off-by: Raül <[email protected]>
🧪 CI InsightsHere's what we observed from your CI run for 37e96d5. ❌ Job Failures
✅ Passed Jobs With Interesting Signals
|
Description
Fix compilation with GCC 15 by adding missing
#include <cstdint>toSharedSecretHandle.h.GCC 15 is stricter about implicit includes, and
uint8_trequires an explicit#include <cstdint>. Without this include, compilation fails with errors like:Additionally, GCC 15 shows a false positive warning in sqlite3.c:
Which is fixed in this PR by changing the if statement to a ternary operator.
@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x
Fixes #6254
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist