Skip to content

Conversation

@MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jan 19, 2026

Description

This changes the default values in ResourceLimitsQosPolicy to the ones indicated in the DDS 1.4 standard (i.e. unlimited maximum values).

It also restores the consistency check between HistoryQosPolicy and ResourceLimitsQosPolicy, producing RETCODE_INCONSISTENT_POLICY on return.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.5.0 milestone Jan 19, 2026
@MiguelCompany MiguelCompany changed the title Force history QoS consistency and change resource limits default values [24094] Force history QoS consistency and change resource limits default values Jan 19, 2026
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima January 19, 2026 11:21
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 19, 2026
@MiguelCompany MiguelCompany force-pushed the feature/qos_consistencies branch from 7771e3b to 7918878 Compare January 20, 2026 11:55
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany added the doc-pending Issue or PR which is pending to be documented label Jan 20, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 21, 2026

🧪 CI Insights

Here's what we observed from your CI run for 0614261.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Ubuntu CI ubuntu-ci / fastdds_discovery_server_test (RelWithDebInfo) Unknown 0 View View
ubuntu-ci / fastdds_docs_test (RelWithDebInfo) Unknown 0 View View
ubuntu-ci / fastdds_test (RelWithDebInfo) Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, blackbox), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, blackbox), v143 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, unittest-II), v142 Unknown 0 View View

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS Ubuntu CI ubuntu-ci / fastdds_build (RelWithDebInfo) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running doc-pending Issue or PR which is pending to be documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants