-
Notifications
You must be signed in to change notification settings - Fork 891
[23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) #6238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mergify
wants to merge
3
commits into
2.14.x
Choose a base branch
from
mergify/bp/2.14.x/pr-6217
base: 2.14.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <[email protected]> * Add tests Signed-off-by: Emilio Cuesta <[email protected]> * Uncrustify Signed-off-by: Emilio Cuesta <[email protected]> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <[email protected]> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <[email protected]> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <[email protected]> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <[email protected]> * Uncrustify Signed-off-by: Emilio Cuesta <[email protected]> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <[email protected]> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <[email protected]> * Fix asan problems Signed-off-by: Emilio Cuesta <[email protected]> * Apply easy suggestions from code review Co-authored-by: Miguel Company <[email protected]> Signed-off-by: Emilio Cuesta Fernandez <[email protected]> * Apply revision part2 Signed-off-by: Emilio Cuesta <[email protected]> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <[email protected]> Signed-off-by: Emilio Cuesta Fernandez <[email protected]> * Replace old signature name Signed-off-by: Emilio Cuesta <[email protected]> * Remove unnecessary check Signed-off-by: Emilio Cuesta <[email protected]> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <[email protected]> * Removing line Signed-off-by: Emilio Cuesta <[email protected]> --------- Signed-off-by: Emilio Cuesta <[email protected]> Signed-off-by: Emilio Cuesta Fernandez <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 47bfac0) # Conflicts: # examples/cpp/topic_instances/SubscriberApp.cpp # examples/cpp/topic_instances/SubscriberApp.hpp # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/unittest/dds/publisher/DataWriterTests.cpp # test/unittest/rtps/reader/CMakeLists.txt # test/unittest/rtps/reader/StatefulReaderTests.cpp
Contributor
Author
|
Cherry-pick of 47bfac0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
10 tasks
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
7f3d4ca to
9faa591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the handling of dispose and unregister operations when payloads are empty, and enhances test coverage for these scenarios. Until now, it was not possible to send those messages with empty payloads, now it is allowed as long as a valid instance handle is provided.
@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6217 done by [Mergify](https://mergify.com).