[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. by KeaneWong · Pull Request #207 · eProsima/Fast-DDS-python

KeaneWong · 2025-02-20T19:43:53Z

Description

Currently, the way that CMake creates the library files always generates .dylib files on Mac. Compilation will work fine, but attempting to import in any Python app will cause the import to fail, as the interpreter expects .so files for library files.
For some reason, using the flag
--cmake-args " -DCMAKE_SHARED_LIBRARY_SUFFIX=.so"
does not fix the issue. Additionally, setting the variable before the project() line in the CMakeLists also remains inneffective. So, the workaround is to add
set(CMAKE_SHARED_LIBRARY_SUFFIX .so)
right after the project() line.

@Mergifyio backport 2.3.x 2.2.x 1.4.x

Fixes #206

Contributor Checklist

Commit messages follow the project guidelines.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Changes are API compatible.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

fastdds_python/CMakeLists.txt

fastdds_python/test/types/CMakeLists.txt

Signed-off-by: danipiza <[email protected]>

Signed-off-by: Miguel Company <[email protected]>

MiguelCompany · 2025-09-25T08:06:42Z

CI:

MiguelCompany · 2025-09-25T08:41:46Z

@Mergifyio backport 2.3.x 2.2.x 1.4.x

mergify · 2025-09-25T08:41:52Z

backport 2.3.x 2.2.x 1.4.x

✅ Backports have been created

Details

#257 [#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. (backport #207) has been created for branch 2.3.x
#258 [#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. (backport #207) has been created for branch 2.2.x
#259 [#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. (backport #207) has been created for branch 1.4.x but encountered conflicts

* Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. * [#23543] Added cmake option and default suffix for platforms Signed-off-by: danipiza <[email protected]> * [#23543] Added cmake option for Python test and examples Signed-off-by: danipiza <[email protected]> * [#23543] Default value for Windows OS Signed-off-by: danipiza <[email protected]> * [#23543] Review changes Signed-off-by: danipiza <[email protected]> * Refs #23543. Regenerate code with Fast DDS Gen from related PR. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: danipiza <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Keane Wong <[email protected]> Co-authored-by: danipiza <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 57a5541)

* Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. * [#23543] Added cmake option and default suffix for platforms Signed-off-by: danipiza <[email protected]> * [#23543] Added cmake option for Python test and examples Signed-off-by: danipiza <[email protected]> * [#23543] Default value for Windows OS Signed-off-by: danipiza <[email protected]> * [#23543] Review changes Signed-off-by: danipiza <[email protected]> * Refs #23543. Regenerate code with Fast DDS Gen from related PR. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: danipiza <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Keane Wong <[email protected]> Co-authored-by: danipiza <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 57a5541) # Conflicts: # fastdds_python/test/types/test_complete.i # fastdds_python/test/types/test_modules.i # fastdds_python_examples/RPCExample/generated_code/CMakeLists.txt

* Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. * [#23543] Added cmake option and default suffix for platforms * [#23543] Added cmake option for Python test and examples * [#23543] Default value for Windows OS * [#23543] Review changes * Refs #23543. Regenerate code with Fast DDS Gen from related PR. --------- (cherry picked from commit 57a5541) Signed-off-by: danipiza <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Keane Dixon Wong <[email protected]> Co-authored-by: Keane Wong <[email protected]> Co-authored-by: danipiza <[email protected]> Co-authored-by: Miguel Company <[email protected]>

Danipiza force-pushed the fix/mac-dylib-generation branch from 52c299e to a336102 Compare July 30, 2025 09:47

Danipiza changed the title ~~Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.~~ [#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. Jul 30, 2025

richiware requested changes Aug 26, 2025

View reviewed changes

fastdds_python/CMakeLists.txt Show resolved Hide resolved

fastdds_python/test/types/CMakeLists.txt Show resolved Hide resolved

Danipiza mentioned this pull request Sep 22, 2025

[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. eProsima/Fast-DDS-Gen#504

Merged

9 tasks

MiguelCompany requested a review from richiware September 25, 2025 07:27

Keane Wong and others added 6 commits September 25, 2025 09:51

Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.

17d3eb0

[#23543] Added cmake option and default suffix for platforms

2e2e880

Signed-off-by: danipiza <[email protected]>

[#23543] Added cmake option for Python test and examples

8d5468b

Signed-off-by: danipiza <[email protected]>

[#23543] Default value for Windows OS

061f3d2

Signed-off-by: danipiza <[email protected]>

[#23543] Review changes

9fcf244

Signed-off-by: danipiza <[email protected]>

Refs #23543. Regenerate code with Fast DDS Gen from related PR.

739e7d9

Signed-off-by: Miguel Company <[email protected]>

MiguelCompany added this to the v2.4.0 milestone Sep 25, 2025

MiguelCompany force-pushed the fix/mac-dylib-generation branch from 6b1355a to 739e7d9 Compare September 25, 2025 07:56

MiguelCompany approved these changes Sep 25, 2025

View reviewed changes

richiware approved these changes Sep 25, 2025

View reviewed changes

MiguelCompany merged commit 57a5541 into eProsima:main Sep 25, 2025
2 checks passed

mergify bot mentioned this pull request Sep 26, 2025

[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. (backport #504) eProsima/Fast-DDS-Gen#512

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.#207

[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.#207
MiguelCompany merged 6 commits intoeProsima:mainfrom
KeaneWong:fix/mac-dylib-generation

KeaneWong commented Feb 20, 2025 •

edited by MiguelCompany

Loading

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Sep 25, 2025

Uh oh!

Uh oh!

MiguelCompany commented Sep 25, 2025

Uh oh!

mergify bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

KeaneWong commented Feb 20, 2025 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Sep 25, 2025

Uh oh!

Uh oh!

MiguelCompany commented Sep 25, 2025

Uh oh!

mergify bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KeaneWong commented Feb 20, 2025 •

edited by MiguelCompany

Loading

mergify bot commented Sep 25, 2025 •

edited

Loading