Fix: Replace z.httpUrl() with z.url() for localhost compatibility#249
Open
taheerahmed wants to merge 1 commit intoe2b-dev:mainfrom
Open
Fix: Replace z.httpUrl() with z.url() for localhost compatibility#249taheerahmed wants to merge 1 commit intoe2b-dev:mainfrom
taheerahmed wants to merge 1 commit intoe2b-dev:mainfrom
Conversation
|
@taheerahmed is attempting to deploy a commit to the E2B Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e30060e057
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ocalhost compatibility z.httpUrl() rejects localhost URLs, causing Zod validation errors during local development when verifying email. z.url() with a protocol constraint still restricts to http/https while accepting localhost. Existing isExternalOrigin checks already handle redirect security. Closes e2b-dev#241
e30060e to
14a91a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
z.httpUrl()withz.url()in the auth confirm route and sharedConfirmEmailInputSchemaz.httpUrl()rejectslocalhostURLs, causing Zod validation errors during local development email verificationz.url()validates URL structure while acceptinglocalhost— production URLs (https://e2b.dev/...) continue to passWhy this is safe
The Zod schema is only responsible for validating that
nextis a syntactically valid URL. The actual redirect security is handled downstream:isExternalOrigin()checks reject or reroute requests with a different originbuildRedirectUrl()reconstructs the redirect using the dashboard's own origin, only preserving pathname and search paramsSo switching from
z.httpUrl()toz.url()does not weaken security.Validation
z.httpUrl()(before)z.url()(after)http://localhost:3000/dashboardhttps://e2b.dev/dashboardnot-a-url(empty)Files changed
src/server/api/models/auth.models.ts—ConfirmEmailInputSchema.nextsrc/app/api/auth/confirm/route.ts—confirmSchema.nextCloses #241