Skip to content

Loosen kap/mle regression gate to hardware-reproducible tolerance #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e-baumer merged 1 commit into from
Aug 12, 2026
Merged

Loosen kap/mle regression gate to hardware-reproducible tolerance #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/test_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ def _load_golden():
GOLDEN = _load_golden()
FIT_KWARGS = {("gam", "mle"): {"floc": 0}, ("wei", "mle"): {"floc": 0}}

DEFAULT_TOL = {"rel": 1e-9}
TOLERANCES = {("kap", "mle"): {"abs": 1e-5}}
"""scipy's kappa4 MLE converges to the same optimum with hardware-dependent
floating-point drift around 1e-7 (observed across GitHub Actions runners), so
kap/mle cannot hold the 1e-9 gate; 1e-5 still catches any real change, which
alters values by 1e-3 or more."""


@pytest.mark.parametrize("dist_type, fit_type", GOLDEN, ids=lambda v: v)
def test_numerical_equivalence(monthly_df, dist_type, fit_type):
Expand All @@ -50,6 +57,7 @@ def test_numerical_equivalence(monthly_df, dist_type, fit_type):
**FIT_KWARGS.get((dist_type, fit_type), {}),
)
assert result["date"].astype(str).tolist() == expected["date"].tolist()
tol = TOLERANCES.get((dist_type, fit_type), DEFAULT_TOL)
assert result["TotalPrecipitation_calculated_index"].values == pytest.approx(
expected["index_value"].values, rel=1e-9, nan_ok=True
expected["index_value"].values, nan_ok=True, **tol
)
Loading