CDO: Introduce log_error()#1456
Merged
joe-lawrence merged 1 commit intodynup:masterfrom May 14, 2025
Merged
Conversation
joe-lawrence
approved these changes
May 12, 2025
Contributor
joe-lawrence
left a comment
joe-lawrence
left a comment
There was a problem hiding this comment.
Seems reasonable. On a related note, too bad there are so many existing ERROR() calls, otherwise we should have called it FATAL() or something to indicate that it means business and will halt the program :)
log_normal() is used in some critical errors, such as: "changed section XXXX not selected for inclusion". It is not very obvious this is a fatal error. Introduce log_error() and use it for critical messages. Note that we are not using ERROR() here, because ERROR() will terminate CDO immediately, which is not the desired behavior. Signed-off-by: Song Liu <song@kernel.org> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com> [merge conflict]
Contributor
|
(The latest two CDO MRs both touch kpatch_verify_patchability(), so I quickly rebased this one to smooth over the merge conflict.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log_normal() is used in some critical errors, such as:
"changed section XXXX not selected for inclusion".
It is not very obvious this is a fatal error.
Introduce log_error() and use it for critical messages.
Note that we are not using ERROR() here, because ERROR() will terminate CDO immediately, which is not the desired behavior.