Fix Rich markup issues with square brackets in user content

[holmboe]

Summary

Fixes two related issues where Rich library incorrectly interprets square brackets in user-provided content as markup syntax:

• Issue Rich MarkupError when task description contains square brackets #135: MarkupError crash when displaying [/path] patterns
• Issue Rich format silently strips square bracket tags from task titles #136: Silent stripping of [bug] tags from task titles

Problem

Rich library treats square brackets [...] as markup syntax for styling/formatting. When user content contains literal square brackets:

1. Pattern [/text] → Interpreted as closing tag → Crashes with MarkupError
2. Pattern [word] → Interpreted as invalid tag → Silently removed from display

Example Issues

T525 - Contains file path [/source/kubespray/...]:

Before: Crashed with MarkupError: closing tag '[/source/...]' doesn't match any open tag
After: Displays correctly with literal brackets

T2163 - Title has [bug] prefix:

Before: ' opensearch-operator-controller-manager OOMKilled '  (missing [bug])
After: '[bug] opensearch-operator-controller-manager OOMKilled '  (correct)

Solution

Use rich.markup.escape() to escape all user-provided content while keeping Rich markup enabled for intentional formatting (hyperlinks, bold labels, etc.).

Implementation

1. Import markup.escape from Rich

2. Add helper method _escape() to safely escape content:

   • Returns empty string for None
   • Preserves Text objects (already safe Rich objects like hyperlinks)
   • Escapes all other content using escape(str(content))

3. Escape user content in 30 locations across 2 display methods:

_display_task_yaml() method (15 locations):

• Task fields (Name, Description, etc.)
• Board/Project names
• Column names
• History transitions
• Comments
• Metadata values

_display_task_tree() method (15 locations):

• Same content types as YAML format

4. Preserve intentional formatting:

   • Hyperlinks created by self.format_link() return Text objects
   • _escape() checks isinstance(content, Text) and doesn't escape them
   • Rich markup in phabfive's own formatting (bold labels, etc.) still works

5. Handle combined escaping:

   • Some values need both YAML quote escaping ('') and Rich markup escaping
   • Applied in correct order: YAML escape first, then Rich escape

Testing

# Issue #135 - Should not crash
uv run phabfive --format=rich maniphest show T525
✅ Displays successfully with [/path] patterns visible

# Issue #136 - Should show [bug] prefix  
uv run phabfive --format=rich maniphest show T2163
✅ Shows full title: '[bug] opensearch-operator-controller-manager OOMKilled '

# Search results
uv run phabfive --format=rich maniphest search --tag DYN127-arkitektur
✅ All tasks display correctly with square brackets preserved

# Strict format still works
uv run phabfive --format=strict maniphest show T525
✅ No regression in strict YAML output

Files Changed

• phabfive/maniphest.py: +55 insertions, -27 deletions
  • Import escape from rich.markup
  • Add _escape() helper method (26 lines)
  • Update 30 print/add statements to escape user content

Impact

Fixes:

• ✅ No more crashes on tasks with [/path] patterns (Rich MarkupError when task description contains square brackets #135)
• ✅ No more silent removal of [bug], [feature], [urgent] tags (Rich format silently strips square bracket tags from task titles #136)
• ✅ All square brackets in user content display correctly

Preserves:

• ✅ Hyperlinks still work (Text objects not escaped)
• ✅ Rich formatting in phabfive's UI (bold, colors) still works
• ✅ --format=strict unaffected (uses different code path)

Related Issues

Closes #135
Closes #136

🤖 Generated with Claude Code