Add 'phabfive edit' command with object type auto-detection

[holmboe]

Summary

Implements a unified phabfive edit command that auto-detects object types from monograms (T/K/P) and provides intelligent batch editing capabilities with atomic validation.

Fixes #132

Features Implemented

Core Functionality

• ✅ Auto-detect object type from monograms (T123, K456, P789)
• ✅ Auto-detect piped input using sys.stdin.isatty() (no --from-stdin flag needed)
• ✅ Batch editing with atomic validation (validate ALL before modifying ANY)
• ✅ Smart board/column handling with auto-detection and partition suggestions
• ✅ Directional navigation for priority and columns (raise/lower, forward/backward)
• ✅ Change detection to only apply actual changes
• ✅ Comment support with --comment flag

Task Editing (Maniphest)

• ✅ Priority management with special Triage(90) skip logic:
  • Ladder: Wish(0) → Low(25) → Normal(50) → High(80) → Unbreak(100)
  • Raise from High → Unbreak (skips Triage)
  • Lower from Unbreak → High (skips Triage)
• ✅ Status management (open, resolved, wontfix, etc.)
• ✅ Column navigation by name (case-insensitive) or direction (forward/backward)
• ✅ Assignment to users
• ✅ Board context validation with helpful error messages

Batch Operations

• ✅ Atomic validation: All tasks validated before any are modified
• ✅ Partition suggestions: Helpful commands when tasks span multiple boards
• ✅ Multi-board handling: Auto-detect single board or require explicit --tag

Architecture

New Files

• phabfive/edit.py (452 lines) - Edit handler with monogram detection, YAML parsing, and validation
• tests/test_edit.py (498 lines) - Comprehensive test suite (34 tests)
• docs/edit-cli.md (603 lines) - Complete documentation with examples and troubleshooting

Modified Files

• phabfive/cli.py - Added edit command and routing
• phabfive/maniphest.py - Added editing methods:
  • edit_task_by_id() - Main edit entry point with change detection
  • _get_task_data() - Fetch task with attachments
  • _navigate_priority() - Priority raise/lower with Triage skip
  • _navigate_column() - Column forward/backward navigation
  • _resolve_user_phid() - Username to PHID resolution
• docs/index.md - Added Edit CLI to documentation index
• README.md - Added edit command to features and examples

Test Coverage

34 comprehensive tests, all passing:

• 6 tests for monogram detection (T/K/P from text and URLs)
• 12 tests for priority navigation (including Triage special cases)
• 7 tests for column navigation (forward/backward/by-name)
• 3 tests for board/column validation
• 2 tests for stdin auto-detection
• 3 tests for YAML parsing
• 1 test for object type grouping

Full test suite: 326/326 tests passing (no regressions)

Usage Examples

Single Task Edit

phabfive edit T123 --priority=high --status=resolved

Batch Edit from Search

phabfive maniphest search --assigned=@me | phabfive edit --status=resolved

Directional Navigation

# Move priority up one level (High → Unbreak, skips Triage)
phabfive edit T123 --priority=raise

# Move to next column
phabfive edit T123 --tag="Sprint" --column=forward

Multi-Board Handling

# Specify board when task is on multiple boards
phabfive maniphest search --assigned=@me | \
  phabfive edit --tag="Sprint 42" --column=Done

Error Handling

Partition Suggestions

When tasks are on different boards, the command provides helpful partition suggestions:

ERROR: Validation failed for 3 task(s):
  - T123: Task T123 is on multiple boards [Backend Team, Sprint 42]. Use --tag=BOARD to specify which board.
  - T124: Task T124 is on multiple boards [Backend Team, Sprint 42]. Use --tag=BOARD to specify which board.

Suggested partition commands:

# Tasks on Backend Team + Sprint 42:
echo "T123\nT124" | phabfive edit --tag="Backend Team" --column=Done

No tasks were modified (atomic batch failure).

Documentation

Complete documentation added in docs/edit-cli.md covering:

• Quick start and command syntax
• All editing capabilities (priority, status, columns, assignment)
• Batch operations and atomic validation
• Advanced workflows and examples by use case
• Error handling and troubleshooting
• Tips and best practices

Commits

1. c4da86c - WIP: Add phabfive edit command skeleton (Add 'phabfive edit' command with object type auto-detection #132)
2. 0d41708 - Implement edit command functionality in maniphest.py (Add 'phabfive edit' command with object type auto-detection #132)
3. 0ee9de1 - Add comprehensive tests for edit command (Add 'phabfive edit' command with object type auto-detection #132)
4. 728878f - Fix column navigation and add comprehensive tests for edit command
5. 8d80b15 - Add comprehensive documentation for edit command

Testing Instructions

# Run edit command tests
uv run pytest tests/test_edit.py -v

# Run full test suite
uv run pytest -v

# Manual testing (requires Phabricator/Phorge instance)
phabfive edit T123 --priority=high --dry-run
phabfive maniphest search --assigned=@me | phabfive edit --column=forward --dry-run

Breaking Changes

None. This is a new command that doesn't affect existing functionality.

Future Work

• Support for Passphrase editing (K monograms)
• Support for Paste editing (P monograms)

The architecture is designed to easily extend to these object types through the existing monogram detection system.

Related

• Depends on Auto-detect --format=strict when output is piped #131 (auto-format detection) - Already merged to master
• Uses same sys.stdin.isatty() pattern for consistency

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com